Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Displayable fingerprint computation depends on platform character set #29

Open
mmdriley opened this issue Oct 18, 2016 · 1 comment
Open

Comments

@mmdriley
Copy link

This call to String.getBytes() should probably be replaced with getBytes(StandardCharsets.UTF_8) or getBytes(Charset.forName("UTF-8")).

Thankfully this seems to default to UTF-8 on Android anyway, though it's still worth being explicit: http://stackoverflow.com/questions/2207631/android-default-character-encoding

@moxie0
Copy link
Contributor

moxie0 commented Oct 19, 2016

There are many calls to getBytes() throughout the entire codebase which do not specify a character encoding. We've always depended on UTF8 being mandatory and default on Android. Maybe one day we'll go through and make them all explicit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants