refactor: rename+improve client.ErrEventNotSupported

`client.ErrEventNotSupported` was a simple sentinel with no information.

Replaced it with `client.EventNotSupportedError`, a struct implementing
error with the offending TypeURL included.

Signed-off-by: Laura Brehm <[email protected]>

Author: laurazard

cmd/talosctl/cmd/talos/events.go

@@ -66,7 +66,8 @@ var eventsCmd = &cobra.Command{
 
 				event, err := client.UnmarshalEvent(ev)
 				if err != nil {
-					if errors.Is(err, client.ErrEventNotSupported) {
+					var errBadEvent client.EventNotSupportedError
+					if errors.As(err, &errBadEvent) {
 						return nil
 					}
 

pkg/machinery/client/events.go

@@ -20,8 +20,15 @@ import (
 	"github.com/siderolabs/talos/pkg/machinery/proto"
 )
 
-// ErrEventNotSupported is returned from the event decoder when we encounter an unknown event.
-var ErrEventNotSupported = errors.New("event is not supported")
+// EventNotSupportedError is returned from the event decoder when we encounter an unknown event.
+type EventNotSupportedError struct {
+	TypeURL string
+}
+
+// Error implements the error interface.
+func (e EventNotSupportedError) Error() string {
+	return fmt.Sprintf("event is not supported: %s", e.TypeURL)
+}
 
 // EventsOptionFunc defines the options for the Events API.
 type EventsOptionFunc func(opts *machineapi.EventsRequest)
@@ -249,9 +256,10 @@ func UnmarshalEvent(event *machineapi.Event) (*Event, error) {
 	}
 
 	if msg == nil {
-		log.Printf("event not supported: %s", typeURL)
 		// We haven't implemented the handling of this event yet.
-		return nil, ErrEventNotSupported
+		return nil, EventNotSupportedError{
+			TypeURL: typeURL,
+		}
 	}
 
 	if err := proto.Unmarshal(event.GetData().GetValue(), msg); err != nil {