Add constants

Author: ramindu90

component/src/main/java/io/siddhi/extension/util/Constant.java

@@ -27,4 +27,7 @@ public class Constant {
     public static final String CREATE_FOLDER = "create-folder";
     public static final String LAST_MODIFIED_DATETIME_FORMAT = "MM/dd/yyyy HH:mm:ss";
     public static final String CREATE = "create";
+    public static final String SFTP_SCHEME_FILE_OPTION = "sftp";
+    public static final String VFS_SCHEME_KEY = "VFS_SCHEME";
+    public static final String FTP_SCHEME_FILE_OPTION = "ftp";
 }

component/src/main/java/io/siddhi/extension/util/Utils.java

@@ -35,6 +35,10 @@
 import java.util.Map;
 import java.util.Properties;
 
+import static io.siddhi.extension.util.Constant.FTP_SCHEME_FILE_OPTION;
+import static io.siddhi.extension.util.Constant.SFTP_SCHEME_FILE_OPTION;
+import static io.siddhi.extension.util.Constant.VFS_SCHEME_KEY;
+
 /**
  * Util Class.
  */
@@ -58,7 +62,7 @@ public static FileObject getFileObject(String filePathUri) {
         } catch (FileSystemException e) {
             throw new SiddhiAppRuntimeException("Exception occurred when getting VFS manager", e);
         }
-        if (sourceOptions != null && "ftp".equals(sourceOptions.get("VFS_SCHEME"))) {
+        if (sourceOptions != null && FTP_SCHEME_FILE_OPTION.equals(sourceOptions.get(VFS_SCHEME_KEY))) {
             FtpFileSystemConfigBuilder.getInstance().setPassiveMode(sourceFso, true);
         }
         try {
@@ -101,18 +105,18 @@ private static Map<String, String> parseSchemeFileOptions(String fileURI, Proper
             return null;
         } else {
             HashMap<String, String> schemeFileOptions = new HashMap();
-            schemeFileOptions.put("VFS_SCHEME", scheme);
+            schemeFileOptions.put(VFS_SCHEME_KEY, scheme);
             addOptions(scheme, schemeFileOptions, properties);
             return schemeFileOptions;
         }
     }
 
     private static void addOptions(String scheme, Map<String, String> schemeFileOptions, Properties properties) {
-        if (scheme.equals("sftp")) {
+        if (scheme.equals(SFTP_SCHEME_FILE_OPTION)) {
             Constants.SftpFileOption[] sftpFileOptions = Constants.SftpFileOption.values();
             for (Constants.SftpFileOption option : sftpFileOptions) {
-                String strValue = (String) properties.get("sftp" + option.toString());
-                if (strValue != null && !strValue.equals("")) {
+                String strValue = (String) properties.get(SFTP_SCHEME_FILE_OPTION + option.toString());
+                if (strValue != null && !strValue.isEmpty()) {
                     schemeFileOptions.put(option.toString(), strValue);
                 }
             }

component/src/test/java/io/siddhi/extension/io/file/FileFunctionsTestCase.java

@@ -1,3 +1,21 @@
+/*
+ * Copyright (c) 2019, WSO2 Inc. (http://www.wso2.org) All Rights Reserved.
+ *
+ * WSO2 Inc. licenses this file to you under the Apache License,
+ * Version 2.0 (the "License"); you may not use this file except
+ * in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
 package io.siddhi.extension.io.file;
 
 import io.siddhi.core.SiddhiAppRuntime;
@@ -1113,7 +1131,7 @@ private boolean isFileExist(String filePathUri, boolean isDirectory) {
                 return fileObj.isFolder();
             }
         } catch (FileSystemException e) {
-            throw new SiddhiAppRuntimeException("Exception occurred when checking type of file in path: " +
+            throw new SiddhiAppRuntimeException("Exception occurred when checking existence for path: " +
                     filePathUri, e);
         }
     }

pom.xml

@@ -125,7 +125,7 @@
             <dependency>
                 <groupId>org.apache.commons</groupId>
                 <artifactId>commons-compress</artifactId>
-                <version>1.14</version>
+                <version>${org.apache.commons-compress.version}</version>
             </dependency>
             <dependency>
                 <groupId>io.siddhi.extension.execution.list</groupId>
@@ -140,6 +140,7 @@
         <siddhi.version>5.1.5</siddhi.version>
         <siddhi.version.range>[5.0.0,6.0.0)</siddhi.version.range>
         <wso2.transport.file.version>6.0.60</wso2.transport.file.version>
+        <org.apache.commons-compress.version>1.14</org.apache.commons-compress.version>
         <testng.version>6.8</testng.version>
         <siddhi.map.json.version>5.0.2</siddhi.map.json.version>
         <siddhi.map.xml.version>5.0.2</siddhi.map.xml.version>