Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback requested for PERSISTENT DISKS DISCUSSION: -e PERSISTENT=true -v "${PWD}/image.img:/image" #455

Open
sickcodes opened this issue Feb 23, 2022 · 5 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@sickcodes
Copy link
Owner

I have estimated the amount of human time it takes people to create and copy/mv out images and I think it's high. I want to add persistent disks on the first run (add the ability, nothing being removed, all old processes work, as I will never deprecated anything)

Take note, all of this is done OUTSIDE of Docker, but also consider that to get the image from INSIDE the Docker, it will take work also.

Option 1:

Should I add a (default) check (for every single container) where you can say you want

qemu-img create -f qcow2 image.img 512G

    -e PERSISTENT=true \
    -v "${PWD}/image.img:/image" \

Option 2:

Or the same, but it it will just check if you're supplying an image instead of using PERSISTENT, it will just realise /image, is a raw .img, without PERSISTENT=true needed

qemu-img create -f qcow2 image.img 512G

    -v "${PWD}/image.img:/image" \

Option 3:

If users might accidentally overwrite their disk, use date, for example:

This will create in current directory ./image_2022-02-23-16:24:11.img, format it to skip disk utility step.

NEW_IMAGE=./image_$(date +%F-%T).img
echo "${NEW_IMAGE}"

# turn on network block device kernel module from libvirtd
sudo modprobe nbd

# create a disk
# AND FORMAT IT TOO TO SKIP THE DISK UTILITY STEP
qemu-img create -f qcow2 "${NEW_IMAGE}" 512G
sudo qemu-nbd --connect=/dev/nbd0 ${NEW_IMAGE}
sudo mkfs.apfs /dev/nbd0
sudo qemu-nbd --disconnect /dev/nbd0


    -v "${PWD}/${NEW_IMAGE}:/image" \

Option 4:

Or leave everything as-is.

@sickcodes sickcodes changed the title Feedback required for PERSISTENT DISKS DISCUSSION: -e PERSISTENT=true -v "${PWD}/image.img:/image" Feedback requested for PERSISTENT DISKS DISCUSSION: -e PERSISTENT=true -v "${PWD}/image.img:/image" Feb 23, 2022
@sickcodes sickcodes added enhancement New feature or request question Further information is requested documentation Improvements or additions to documentation help wanted Extra attention is needed labels Feb 23, 2022
@sickcodes
Copy link
Owner Author

Option 5: add all of the above

@spantheslayer
Copy link

spantheslayer commented Feb 23, 2022

Why don't you add all of them 😂

But personally would love to see (default) check (for every single container) being implemented. This will be a really neat feature to have.

@omarahm3
Copy link

would be really great if you can add all of the options, but if i had to choose, i would love to see option 3

@ballerxdakid
Copy link

i would agree with above be nice with all but number one but to be honest what ever you choose thanks for you work my g my g

@sickcodes
Copy link
Owner Author

Adding the most simple way here:

#456

  • Move /home/arch/OSX-KVM to /home/arch/Docker-OSX/OSX-KVM, but symlink it anyway

  • If you put an image at /image, the image will use that at runtime.

  • Move OSX-KVM to submodule, and symlink for perfect redundancy ln -s /home/arch/Docker-OSX/OSX-KVM /home/arch/OSX-KVM

The submodule move is to make OSX-KVM static, if sometimes we are behind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants