Fixed tests

src/Command/AbstractCommand.php

@@ -242,7 +242,7 @@ protected function assembleOptionString()
             } elseif (is_string($option) && $option !== '') {
                 $optionString .= " {$name} " . escapeshellarg($option);
             } elseif (is_array($option) && !empty($option)) {
-                $optionString .= " {$name} " . implode(' ', escapeshellarg($option));
+                $optionString .= " {$name} " . implode(' ', $option);
             }
         }
 

tests/Command/AddremoveCommandTest.php

@@ -30,7 +30,7 @@ public function addremoveCommand()
         $addremoveCmd->setDryRun(true);
 
         $file = '\'C:\xampp\file1\\\' \'C:\xampp\file2\\\'';
-        $expected = 'hg addremove --similarity 50 --include includePattern --exclude excludePattern --dry-run ';
+        $expected = 'hg addremove --similarity ' . escapeshellarg('50') . ' --include includePattern --exclude excludePattern --dry-run ';
 
         if (strtoupper(substr(PHP_OS, 0, 3)) === 'WIN') {
             $file = str_replace("'", '"', $file);

tests/Command/BackoutCommandTest.php

@@ -33,7 +33,7 @@ public function backoutCommand()
         $backoutCmd->setUser('user');
 
         $revision = '\'revision\'';
-        $expected = 'hg backout --merge --tool tool --include includePattern --exclude excludePattern --message text --logfile logfile --date date --user user ';
+        $expected = 'hg backout --merge --tool ' . escapeshellarg('tool') . ' --include includePattern --exclude excludePattern --message ' . escapeshellarg('text') . ' --logfile ' . escapeshellarg('logfile') . ' --date ' . escapeshellarg('date') . ' --user ' . escapeshellarg('user') . ' ';
 
         if (strtoupper(substr(PHP_OS, 0, 3)) === 'WIN') {
             $revision = str_replace("'", '"', $revision);

tests/Command/BookmarksCommandTest.php

@@ -29,7 +29,7 @@ public function bookmarksCommand()
         $bookmarksCmd->setRename('name');
 
         $name = '\'test1\' \'test2\'';
-        $expected = 'hg bookmarks --force --rev revision --rename name ';
+        $expected = 'hg bookmarks --force --rev ' . escapeshellarg('revision') . ' --rename ' . escapeshellarg('name') . ' ';
 
         if (strtoupper(substr(PHP_OS, 0, 3)) === 'WIN') {
             $name = str_replace("'", '"', $name);

tests/Command/BundleCommandTest.php

@@ -31,7 +31,7 @@ public function bundleCommand()
 
         $destination = '\'C:\xampp\dest\\\'';
         $file = '\'C:\xampp\file\\\'';
-        $expected = 'hg bundle --verbose --encoding UTF-8 --ssh testSSH --insecure ';
+        $expected = 'hg bundle --verbose --encoding ' . escapeshellarg('UTF-8') . ' --ssh ' . escapeshellarg('testSSH') . ' --insecure ';
 
         if (strtoupper(substr(PHP_OS, 0, 3)) === 'WIN') {
             $destination = str_replace("'", '"', $destination);

tests/Command/CatCommandTest.php

@@ -31,7 +31,7 @@ public function catCommand()
         $catCmd->setDecode(true);
 
         $file = '\'C:\xampp\file1\\\' \'C:\xampp\file2\\\'';
-        $expected = 'hg cat --output output --rev revision --decode --include includePattern --exclude excludePattern ';
+        $expected = 'hg cat --output ' . escapeshellarg('output') . ' --rev ' . escapeshellarg('revision') . ' --decode --include includePattern --exclude excludePattern ';
 
         if (strtoupper(substr(PHP_OS, 0, 3)) === 'WIN') {
             $file = str_replace("'", '"', $file);

tests/Command/CommitCommandTest.php

@@ -38,7 +38,7 @@ public function commitCommand()
         $commitCmd->setSubrepos(true);
 
         $file = '\'C:\xampp\file1\\\' \'C:\xampp\file2\\\'';
-        $expected = 'hg commit --addremove --close-branch --amend --secret --edit --include includePattern --exclude excludePattern --message text --logfile logfile --date date --user user --subrepos ';
+        $expected = 'hg commit --addremove --close-branch --amend --secret --edit --include includePattern --exclude excludePattern --message ' . escapeshellarg('text') . ' --logfile ' . escapeshellarg('logfile') . ' --date ' . escapeshellarg('date') . ' --user ' . escapeshellarg('user') . ' --subrepos ';
 
         if (strtoupper(substr(PHP_OS, 0, 3)) === 'WIN') {
             $file = str_replace("'", '"', $file);

tests/Command/HeadsCommandTest.php

@@ -27,7 +27,7 @@ public function headsCommand()
         $headsCmd->setRev('startrev');
         $headsCmd->setTopo(true);
 
-        $expected = 'hg heads --rev startrev --topo --closed --template template';
+        $expected = 'hg heads --rev ' . escapeshellarg('startrev') . ' --topo --closed --template ' . escapeshellarg('template');
 
         $this->assertSame($expected, $headsCmd->asString());
     }

tests/Command/ImportCommandTest.php

@@ -37,7 +37,7 @@ public function importCommand()
         $importCmd->setSimilarity('similarity');
 
         $patch = '\'patch1\' \'patch2\'';
-        $expected = 'hg import --strip num --edit --no-commit --bypass --exact --import-branch --message text --logfile logfile --date date --user user --similarity similarity ';
+        $expected = 'hg import --strip ' . escapeshellarg('num') . ' --edit --no-commit --bypass --exact --import-branch --message ' . escapeshellarg('text') . ' --logfile ' . escapeshellarg('logfile') . ' --date ' . escapeshellarg('date') . ' --user ' . escapeshellarg('user') . ' --similarity ' . escapeshellarg('similarity') . ' ';
 
         if (strtoupper(substr(PHP_OS, 0, 3)) === 'WIN') {
             $patch = str_replace("'", '"', $patch);

tests/Command/InitCommandTest.php

@@ -29,7 +29,7 @@ public function initCommand()
         $initCmd->setEncoding('UTF-8');
 
         $destination = '\'C:\xampp\dest\\\'';
-        $expected = 'hg init --verbose --encoding UTF-8 --ssh testSSH --insecure ';
+        $expected = 'hg init --verbose --encoding ' . escapeshellarg('UTF-8') . ' --ssh ' . escapeshellarg('testSSH') . ' --insecure ';
 
         if (strtoupper(substr(PHP_OS, 0, 3)) === 'WIN') {
             $destination = str_replace("'", '"', $destination);

tests/Command/ManifestCommandTest.php

@@ -25,7 +25,7 @@ public function manifestCommand()
         $manifestCmd->setRev('test');
         $manifestCmd->setAll(true);
 
-        $expected = 'hg manifest --rev test --all';
+        $expected = 'hg manifest --rev ' . escapeshellarg('test') . ' --all';
 
         $this->assertSame($expected, $manifestCmd->asString());
     }

tests/Command/MergeCommandTest.php

@@ -26,7 +26,7 @@ public function mergeCommand()
         $mergeCmd->setTool('testtool');
         $mergeCmd->setPreview(true);
 
-        $expected = 'hg merge --rev revision --preview --tool testtool';
+        $expected = 'hg merge --rev ' . escapeshellarg('revision') . ' --preview --tool ' . escapeshellarg('testtool');
 
         $this->assertSame($expected, $mergeCmd->asString());
     }

tests/Command/ParentsCommandTest.php

@@ -27,7 +27,7 @@ public function parentsCommand()
         $parentsCmd->setTemplate('template');
 
         $file = '\'C:\xampp\file\\\'';
-        $expected = 'hg parents --rev revision --template template ';
+        $expected = 'hg parents --rev ' . escapeshellarg('revision') . ' --template ' . escapeshellarg('template') . ' ';
 
         if (strtoupper(substr(PHP_OS, 0, 3)) === 'WIN') {
             $file = str_replace("'", '"', $file);

tests/Command/PhaseCommandTest.php

@@ -27,7 +27,7 @@ public function phaseCommand()
         $phaseCmd->setVerbose(true);
         $phaseCmd->setEncoding('UTF-8');
 
-        $expected = 'hg phase --verbose --encoding UTF-8 --public --force';
+        $expected = 'hg phase --verbose --encoding ' . escapeshellarg('UTF-8') . ' --public --force';
 
         $this->assertSame($expected, $phaseCmd->asString());
     }

tests/Command/PullCommandTest.php

@@ -34,7 +34,7 @@ public function pullCommand()
         $pullCmd->setEncoding('UTF-8');
 
         $source = '\'C:\xampp\source\\\'';
-        $expected = 'hg pull --verbose --encoding UTF-8 --rev rev1 rev2 --bookmark bookmark --branch branch --ssh testSSH --insecure ';
+        $expected = 'hg pull --verbose --encoding ' . escapeshellarg('UTF-8') . ' --rev rev1 rev2 --bookmark bookmark --branch branch --ssh ' . escapeshellarg('testSSH') . ' --insecure ';
 
         if (strtoupper(substr(PHP_OS, 0, 3)) === 'WIN') {
             $source = str_replace("'", '"', $source);

tests/Command/PushCommandTest.php

@@ -30,7 +30,7 @@ public function pushCommand()
         $pushCmd->setEncoding('UTF-8');
 
         $destination = '\'C:\xampp\dest\\\'';
-        $expected = 'hg push --verbose --encoding UTF-8 --ssh testSSH --insecure ';
+        $expected = 'hg push --verbose --encoding ' . escapeshellarg('UTF-8') . ' --ssh ' . escapeshellarg('testSSH') . ' --insecure ';
 
         if (strtoupper(substr(PHP_OS, 0, 3)) === 'WIN') {
             $destination = str_replace("'", '"', $destination);

tests/Command/ResolveCommandTest.php

@@ -34,7 +34,7 @@ public function resolveCommand()
         $resolveCmd->setNoStatus(true);
 
         $file = '\'C:\xampp\file1\\\' \'C:\xampp\file2\\\'';
-        $expected = 'hg resolve --all --list --mark --unmark --no-status --tool testtool --include includePattern --exclude excludePattern ';
+        $expected = 'hg resolve --all --list --mark --unmark --no-status --tool ' . escapeshellarg('testtool') . ' --include includePattern --exclude excludePattern ';
 
         if (strtoupper(substr(PHP_OS, 0, 3)) === 'WIN') {
             $file = str_replace("'", '"', $file);

tests/Command/RevertCommandTest.php

@@ -33,7 +33,7 @@ public function revertCommand()
         $revertCmd->setDryRun(true);
 
         $name = '\'name1\' \'name2\'';
-        $expected = 'hg revert --all --date date --rev revision --no-backup --include includePattern --exclude excludePattern --dry-run ';
+        $expected = 'hg revert --all --date ' . escapeshellarg('date') . ' --rev ' . escapeshellarg('revision') . ' --no-backup --include includePattern --exclude excludePattern --dry-run ';
 
         if (strtoupper(substr(PHP_OS, 0, 3)) === 'WIN') {
             $name = str_replace("'", '"', $name);

tests/Command/TagCommandTest.php

@@ -34,7 +34,7 @@ public function tagCommand()
         $tagCmd->setUser('user');
 
         $name = 'rev rev2';
-        $expected = 'hg tag --force --local --rev test --remove --edit --message text --date date --user user ';
+        $expected = 'hg tag --force --local --rev ' . escapeshellarg('test') . ' --remove --edit --message ' . escapeshellarg('text') . ' --date ' . escapeshellarg('date') . ' --user ' . escapeshellarg('user') . ' ';
 
         $this->assertSame($name, implode(' ', $tagCmd->getName()));
         $this->assertSame($expected . $name, $tagCmd->asString());

tests/Command/UpdateCommandTest.php

@@ -27,7 +27,7 @@ public function updateCommand()
         $updateCmd->setDate('date');
         $updateCmd->setRev('rev');
 
-        $expected = 'hg update --clean --check --date date --rev rev';
+        $expected = 'hg update --clean --check --date ' . escapeshellarg('date') . ' --rev ' . escapeshellarg('rev');
 
         $this->assertSame($expected, $updateCmd->asString());
     }