Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a hide rating option on all the tables #34

Open
shrinish123 opened this issue Dec 22, 2022 · 13 comments
Open

Add a hide rating option on all the tables #34

shrinish123 opened this issue Dec 22, 2022 · 13 comments
Assignees

Comments

@shrinish123
Copy link
Owner

Right now we are show the ratings on all tables. There should be a simple option to hide ratings or show ratings

@MaYaNkKashyap681
Copy link
Contributor

can I work on this?

@shrinish123
Copy link
Owner Author

Yes you can go ahead and work on this issue

@MaYaNkKashyap681
Copy link
Contributor

Can we make a separate settings page and keep this logic along with the user profile as we have on codeforces?

@MaYaNkKashyap681
Copy link
Contributor

And use Context to set the tags-related and theme-related settings over there.

@shrinish123
Copy link
Owner Author

I think building the entire user profile and all the other stuff will be very big, and will work on it later on , for now we can just make this small custom setting

@MaYaNkKashyap681
Copy link
Contributor

MaYaNkKashyap681 commented Dec 23, 2022

As you wish sir, but I can do it in 2 days.

@MaYaNkKashyap681
Copy link
Contributor

Is this okay or do you need something else?
Screenshot (120)
Screenshot (121)

@shrinish123
Copy link
Owner Author

Good work you can make a PR i guess

@MaYaNkKashyap681
Copy link
Contributor

I have used user context to toggle rating, would you like a different context for it or is it okay?

@MaYaNkKashyap681
Copy link
Contributor

I have used user context to toggle rating, would you like a different context for it or is it okay?

You have not told me anything yet, should I make a PR or do you want me to use a separate context?

@shrinish123
Copy link
Owner Author

No I think it's good ,I checked it now.You can make a PR

@MaYaNkKashyap681
Copy link
Contributor

I have made a PR check it.

@shrinish123
Copy link
Owner Author

good work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants