Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JOSS Review: Installation instructions should include list of dependencies #4

Open
mwcraig opened this issue Sep 22, 2019 · 1 comment
Open

JOSS Review: Installation instructions should include list of dependencies #4

mwcraig opened this issue Sep 22, 2019 · 1 comment

Comments

@mwcraig
Copy link

mwcraig commented Sep 22, 2019

One of the checklist items is "Installation instructions: Is there a clearly-stated list of dependencies?". I don't see that list in the installation instructions.

In addition, the dev install instructions say einsteinpy in a couple of places instead of oifits.

openjournals/joss-reviews#1743
@shreyasbapat
Copy link
Owner

Oh, true. I took that directly from einsteinpy. And again. This is all because of the hurry. I am really really sorry for this kind of submission. I will never repeat these mistakes again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mwcraig @shreyasbapat