src/models/Template.js (1)

26-28: Add JSDoc documentation for consistency

Consider adding JSDoc documentation to maintain consistency with the codebase style.

Add documentation like this:

+ /**
+  * Sets the border color for the template
+  * @param {string} borderColor - CSS color value (hex, rgb, rgba, or named color)
+  * @throws {Error} If the color format is invalid
+  */
  setBorderColor(borderColor) {

src/api/controllers/quotesController.js (1)

21-22: Consider architectural improvements.

While the implementation works, consider these enhancements for better maintainability:

1. Move the default border color to a constants file along with other default values
2. Add JSDoc comments to document the new borderColor parameter

Example implementation:

+/**
+ * @typedef {Object} QuoteParams
+ * @property {string} [borderColor] - Custom border color in valid CSS format (hex, rgb, rgba, or named color)
+ */

+// In constants.js
+const DEFAULT_BORDER_COLOR = 'rgba(0, 0, 0, 0.2)';

-    let borderColor = req.query.borderColor || 'rgba(0, 0, 0, 0.2)';
+    let borderColor = req.query.borderColor || DEFAULT_BORDER_COLOR;

src/api/services/quotesService.js (2)

Line range hint 56-58: Enhance error handling with specific error types.

The current error handling simply re-throws the error without providing specific context about what went wrong.

Consider implementing more specific error handling:

  } catch (error) {
-   throw error;
+   if (error.message === 'Invalid border color provided') {
+     throw new Error(`Invalid border color: ${borderColor}. Please provide a valid CSS color value.`);
+   }
+   throw new Error(`Failed to generate quote template: ${error.message}`);
  }

---

Line range hint 13-17: Add JSDoc documentation for the getQuote function.

The function parameters and their types should be documented, especially with the new borderColor parameter.

Add documentation above the function:

+/**
+ * Generates a quote template with customization options
+ * @param {Object} quoteObj - The quote configuration object
+ * @param {string} [quoteObj.borderColor] - CSS color value for the template border
+ * @param {string} [quoteObj.theme] - Template theme
+ * @param {string} [quoteObj.animation] - Animation type
+ * @param {string} [quoteObj.layout] - Template layout
+ * @param {string} [quoteObj.quotesUrl] - Custom quotes URL
+ * @param {string} [quoteObj.quoteCategory] - Quote category
+ * @param {string} [quoteObj.font] - Font family
+ * @param {string} [quoteObj.quoteType] - Type of quote
+ * @returns {Promise<string>} The generated SVG template
+ * @throws {Error} When border color is invalid or template generation fails
+ */

README.md (2)

245-246: Fix typo in parameter description.

There's a typo in the word "parameter".

-Use `?borderColor=COLOR` paramater as shown below
+Use `?borderColor=COLOR` parameter as shown below

---

247-252: Add more comprehensive examples.

The example could be enhanced by showing multiple color format options.

 ```md
 ![Quote](https://github-readme-quotes-bay.vercel.app/quote?borderColor=green)
+![Quote](https://github-readme-quotes-bay.vercel.app/quote?borderColor=%23FF0000)

+

</blockquote></details>
<details>
<summary>src/layouts/layout.js (1)</summary><blockquote>

`14-14`: **Consider extending border customization across all layouts.**

The current implementation only allows border color customization in the default layout. Consider:

1. Extending this feature to other layouts for consistency
2. Creating a comprehensive border customization system that could include:
   - Border width
   - Border style
   - Border radius

This would provide a more consistent and scalable approach across all layouts.

Would you like me to propose a comprehensive border customization implementation that works across all layouts?

</blockquote></details>

</blockquote></details>

<details>
<summary>📜 Review details</summary>

**Configuration used: CodeRabbit UI**
**Review profile: CHILL**

<details>
<summary>📥 Commits</summary>

Reviewing files that changed from the base of the PR and between f3f290228d0dffef80ef5de4f776dd5ddeb8a4ae and 8ed21011ec7f6d04b3b56cddbbc69d57f5149d1f.

</details>

<details>
<summary>📒 Files selected for processing (5)</summary>

* `README.md` (1 hunks)
* `src/api/controllers/quotesController.js` (2 hunks)
* `src/api/services/quotesService.js` (2 hunks)
* `src/layouts/layout.js` (1 hunks)
* `src/models/Template.js` (1 hunks)

</details>

<details>
<summary>🔇 Additional comments (5)</summary>

<details>
<summary>src/api/controllers/quotesController.js (2)</summary>

`44-45`: **LGTM!**

The borderColor property is correctly added to the quoteObject, maintaining consistent formatting with other properties.

---

Line range hint `21-45`: **Verify template integration.**

Let's ensure the borderColor parameter is properly integrated with the template system.

<details>
<summary>✅ Verification successful</summary>

**Border color parameter is properly integrated with the template system** 

The verification shows that:
- The border color is correctly applied in the layout template (`layout.js`) using template literals
- The Template model (`Template.js`) has the proper setter method `setBorderColor`
- The quotes service correctly sets the border color on the template before generation
- The implementation forms a complete chain from controller to final rendering



</details>

<details>
<summary>🏁 Scripts executed</summary>

The following scripts were executed for the analysis:

Script:

```shell
#!/bin/bash
# Description: Verify the borderColor parameter integration with templates

# Check if the template system handles the borderColor parameter
echo "Checking template integration..."
rg -l "borderColor" "src/layouts/"

# Verify error handling in the template system
echo "Checking error handling..."
rg -l "setBorderColor" "src/api/services/"

Length of output: 267

---

Script:

#!/bin/bash
# Let's examine how borderColor is used in the layout and service files

echo "Checking layout.js implementation:"
rg -A 5 "borderColor" "src/layouts/layout.js"

echo "\nChecking quotesService.js implementation:"
rg -A 5 "setBorderColor" "src/api/services/quotesService.js"

# Also check if there are any template files that might need the parameter
echo "\nChecking template files:"
fd "template" --type f --exec rg -l "border"

Length of output: 817

---

Script:

#!/bin/bash
# Let's check the Template model implementation
echo "Checking Template.js implementation:"
rg -A 5 "setBorderColor|borderColor" "src/models/Template.js"

# Let's also verify if there are any test files covering this functionality
echo "\nChecking test coverage:"
fd "test|spec" --type f --exec rg -l "borderColor"

Length of output: 381

52-52: Verify Template class implementation.

The code calls setBorderColor on the template instance, but we need to verify its implementation in the Template class.

#!/bin/bash
# Description: Verify Template class implementation and usage
# Test 1: Check if setBorderColor method is properly implemented
ast-grep --pattern 'class Template {
  $$$
  setBorderColor($_) {
    $$$
  }
  $$$
}'

# Test 2: Check for any existing usage of setBorderColor
rg "setBorderColor" -A 2

239-254: Documentation aligns well with the PR objectives.

The new border color feature is well-documented and matches the requirements from issue #332. The section maintains consistency with the rest of the README structure and provides clear usage instructions.

14-14: Verify template.borderColor implementation.

Let's verify the complete implementation of the border color feature across the codebase.

#!/bin/bash
# Description: Verify the implementation of template.borderColor

# Test 1: Check for borderColor property definition
echo "Checking for borderColor property definition..."
rg -l "borderColor|border.*color" --type js

# Test 2: Check for related test files
echo -e "\nChecking for related test files..."
fd -e test.js -e spec.js

# Test 3: Check for validation implementation
echo -e "\nChecking for color validation..."
rg -l "validateColor|sanitizeColor|isValidColor" --type js

# Test 4: Check for documentation
echo -e "\nChecking for documentation..."
fd README.md | xargs rg -l "borderColor"

#!/bin/bash
# Check Template model definition
echo "=== Template.js model definition ==="
rg -A 5 -B 5 "borderColor" src/models/Template.js

# Check layout implementation
echo -e "\n=== Layout implementation ==="
rg -A 5 -B 5 "borderColor" src/layouts/layout.js

# Check frontend usage
echo -e "\n=== Frontend usage ==="
rg -A 5 -B 5 "borderColor" frontend/src/util/layouts/index.js

# Check API implementation
echo -e "\n=== API implementation ==="
rg -A 5 -B 5 "borderColor" src/api/services/quotesService.js
rg -A 5 -B 5 "borderColor" src/api/controllers/quotesController.js