Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pY] Yafc crashes with "enable all feature flags" #322

Closed
WarlordFTW opened this issue Oct 21, 2024 · 1 comment · Fixed by #324
Closed

[pY] Yafc crashes with "enable all feature flags" #322

WarlordFTW opened this issue Oct 21, 2024 · 1 comment · Fixed by #324
Assignees
Labels
bug Something isn't working

Comments

@WarlordFTW
Copy link

WarlordFTW commented Oct 21, 2024

error with Pyanodons:

(pycoalprocessing, prototypes/technologies/stacking-belts.lua):1: attempt to index global 'feature_flags' (a nil value)
stack traceback:
[C]: in function '__index'
(pycoalprocessing, prototypes/technologies/stacking-belts.lua):1: in main chunk
[C]: in function 'require'
(pycoalprocessing, data-updates.lua):7: in main chunk

I no longer get error when removing enable all feature flags because belt stacking is gone. But in this case, most of the tech is still inaccessible and none of the sciencepacks have recipes.

I've attached the mod settings and mod-list in the zip file

mod-settings.zip

@WarlordFTW WarlordFTW added the bug Something isn't working label Oct 21, 2024
@shpaass shpaass changed the title 2.0 with py and other mods Yafc crashes with "enable all feature flags" Oct 21, 2024
@shpaass shpaass changed the title Yafc crashes with "enable all feature flags" [pY] Yafc crashes with "enable all feature flags" Oct 21, 2024
@SWeini
Copy link
Collaborator

SWeini commented Oct 23, 2024

regarding the feature_flags global, this is its documentation
https://lua-api.factorio.com/latest/types/FeatureFlags.html

we somehow need to populate it with all the required feature flags from loaded mods
I couldn't find updated documentation of info.json, but space-age mod for example includes this:

"quality_required": true,
"space_travel_required": true,
"spoiling_required": true,
"freezing_required": true,
"segmented_units_required": true,
"expansion_shaders_required": true,

from what I remember the devs saying in the beta discord, the feature flags are only enabled if at least one mod requires it - therefore the need to have the enable-all-feature-flags mod

the whole system is made so that mods like py (that don't need the expansion) can check feature_flags and add additional stuff when the player is using the additional features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants