Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checks for non-integral values in strtoi #2

Open
shoooe opened this issue Dec 30, 2014 · 1 comment
Open

Add checks for non-integral values in strtoi #2

shoooe opened this issue Dec 30, 2014 · 1 comment
Labels
enhancement

Comments

@shoooe
Copy link
Owner

shoooe commented Dec 30, 2014

As of right now strtoi will happily (and interpret as numbers) any character in the charset for literals. We must insert some kind of check (probably with enable_if and bounds checking) for valid characters.
@shoooe shoooe added the bug label Dec 30, 2014
@shoooe shoooe self-assigned this Dec 30, 2014
@shoooe
Copy link
Owner Author

shoooe commented Jan 4, 2015

This actually fails now, but the error message could be prettier.

@shoooe shoooe added enhancement and removed bug labels Mar 16, 2015
@shoooe shoooe removed their assignment Mar 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shoooe