#22 tslint eslint migration #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
# Conflicts: # .github/workflows/main.yml # libs/aws/.lintstagedrc.yml # libs/aws/package.json # libs/components/.lintstagedrc.yml # libs/components/package.json # libs/core/.lintstagedrc.yml # libs/core/package.json # package-lock.json # package.json
# Conflicts: # .github/workflows/main.yml # libs/aws/.lintstagedrc.yml # libs/aws/package.json # libs/components/.lintstagedrc.yml # libs/components/package.json # libs/core/.lintstagedrc.yml # libs/core/package.json # package-lock.json # package.json
…#22-tslint-eslint-migration # Conflicts: # .github/workflows/main.yml # libs/aws/.lintstagedrc.yml # libs/aws/package.json # libs/components/.lintstagedrc.yml # libs/components/package.json # libs/core/.lintstagedrc.yml # libs/core/package.json # package-lock.json # package.json
- @shiftcode/[email protected] - @shiftcode/[email protected] - @shiftcode/[email protected]
…#22-tslint-eslint-migration
- @shiftcode/[email protected] - @shiftcode/[email protected] - @shiftcode/[email protected]
…#22-tslint-eslint-migration
- @shiftcode/[email protected] - @shiftcode/[email protected] - @shiftcode/[email protected]
…#22-tslint-eslint-migration # Conflicts: # libs/components/package.json
- @shiftcode/[email protected] - @shiftcode/[email protected] - @shiftcode/[email protected]
- @shiftcode/[email protected] - @shiftcode/[email protected] - @shiftcode/[email protected]
- @shiftcode/[email protected] - @shiftcode/[email protected] - @shiftcode/[email protected]
arisjavet
requested changes
Sep 26, 2024
libs/components/src/lib/click-outside/click-outside.directive.ts
Outdated
Show resolved
Hide resolved
- @shiftcode/[email protected] - @shiftcode/[email protected] - @shiftcode/[email protected]
…#22-tslint-eslint-migration
- @shiftcode/[email protected] - @shiftcode/[email protected] - @shiftcode/[email protected]
arisjavet
requested changes
Oct 24, 2024
- @shiftcode/[email protected] - @shiftcode/[email protected] - @shiftcode/[email protected]
michaelwittwer
requested changes
Dec 11, 2024
| @@ -1,4 +1,3 @@ | |||
| // tslint:disable:no-host-metadata-property | |||
There was a problem hiding this comment.
why is eslint not complaining about that?
There was a problem hiding this comment.
@michaelwittwer
Since we allowed that in our ng-config
https://github.com/shiftcode/sc-commons-public/blob/main/packages/eslint-config-recommended/src/ng-config/index.ts
| @@ -17,7 +7,6 @@ import { Subscription } from 'rxjs' | |||
| */ | |||
| @Directive({ selector: '[scClickOutside]', standalone: true }) | |||
| export class ClickOutsideDirective implements OnDestroy, OnChanges { | |||
| // tslint:disable-next-line:no-input-rename | |||
There was a problem hiding this comment.
why is eslint not complaining about that, compared to tslint?
There was a problem hiding this comment.
@michaelwittwer
Since we don't change the name, that existing input name if I change it to something else we get an error
libs/components/src/lib/tooltip/flexible-connected-position-strategy-2.ts
Outdated
Show resolved
Hide resolved
libs/components/src/lib/tooltip/flexible-connected-position-strategy-2.ts
Outdated
Show resolved
Hide resolved
| @@ -1,5 +1,3 @@ | |||
| // tslint:disable:use-host-property-decorator | |||
| // tslint:disable:no-host-metadata-property | |||
There was a problem hiding this comment.
eslint should also complain or is this allowed in our default config?
There was a problem hiding this comment.
@michaelwittwer
Yes we allowed that
'@angular-eslint/no-host-metadata-property': 'off',
'@angular-eslint/no-host-metadata-property': 'off',
| @@ -110,7 +114,7 @@ export class JwtHelper { | |||
| return true | |||
| } else { | |||
| const date = this.getTokenExpirationDate(token) | |||
|
|
|||
| // eslint-disable-next-line eqeqeq | |||
There was a problem hiding this comment.
use === since this.getTokenExpirationDate will return null or a Date
There was a problem hiding this comment.
@michaelwittwer isn't it better to use !date instead?
vitaliibendyk
force-pushed
the
#22-tslint-eslint-migration
branch
from
a5091f8 to
1216b96
Compare
- @shiftcode/[email protected] - @shiftcode/[email protected] - @shiftcode/[email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on the pulse, the build was without errors.
Kinda mess with commits, needs to be merged with Squash or I can combine a few commits.
By the way, chore commit naming isn't allowed here