Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support aws-sdk-js-v3 #286

Open
michaelwittwer opened this issue Mar 31, 2020 · 23 comments · Fixed by #326
Open

Support aws-sdk-js-v3 #286

michaelwittwer opened this issue Mar 31, 2020 · 23 comments · Fixed by #326

Comments

@michaelwittwer
Copy link
Member

The next generation of the aws-sdk for javascript is in current development. Spin off a branch to test dynamo-easy against the new sdk.

Check the https://github.com/aws/aws-sdk-js-v3#api-changes for things to change.

@pascalbayer
Copy link

Is there a plan when this feature request is going to be implemented?

@michaelwittwer
Copy link
Member Author

@pascalbayer thanks for reaching out. We don't have a clear commitment when this is going to be implemented, generally speaking the staffing for this open source project is currently not clear. We are planning an internal session to clarify on that, let me come back to you. What is a timeline that would make sense for what you are planning todo? Would you be willing and have time to contribute in some way?

@pascalbayer
Copy link

@michaelwittwer my team and I is definitely willing to support on the migration and we have already discussed that we are planning to migrate all of our services to dynamo-easy due to the lack of support for the @aws/dynamodb-data-mapper. In a first step we would like to align on what the plans are for dynamo-easy and how we can best contribute to the replacement of the aws-sdk with v3.

@benheymink
Copy link

Note that AWS will now be bundling V3 of the AWS SDK with the node.js V18.x runtime (https://aws.amazon.com/blogs/compute/node-js-18-x-runtime-now-available-in-aws-lambda/) so would be great to see this happen!

@benheymink
Copy link

@michaelwittwer Is this still on the radar?

@benheymink
Copy link

@michaelwittwer Any updates on this or the future of the project?

@benheymink
Copy link

@pascalbayer We're also tempted to fork this project and attempt to add support for AWS V3, did you start any work on this? (I spotted this fork for example)

@michaelwittwer
Copy link
Member Author

michaelwittwer commented Jan 23, 2023

@benheymink @pascalbayer Thanks for your patience. I quickly wanted to align on a way forward, currently we can't contribute a lot of resources, but I definitely want to unblock this issue by supporting as good as possible. Here are the steps I will tackle as soon as possible (will ping you until end of week):

  • @michaelwittwer Update different libraries, tools to be ready to base new features on
  • @michaelwittwer basic migration to aws-sdk-v3 to identify issues and work items

Let me know if you already started working on this.

@benheymink
Copy link

@michaelwittwer Thanks for the update. No, not started working on it yet, we were just about to start investigating how much effort would be required to move the library over. Will wait for your update towards the end of the week!

@benheymink
Copy link

@michaelwittwer Any updates on this? 🙏

@michaelwittwer
Copy link
Member Author

@benheymink sitting on it. 🙇🏻 Trying to push something today.

@michaelwittwer
Copy link
Member Author

michaelwittwer commented Feb 21, 2023

@pascalbayer @benheymink Got a first version with aws-sdk v3, you can find it on the next branch. The released package including this, can be installed by typing npm i @shiftcoders/[email protected]. This is early stage. I tested it by using it in the demo repo and it worked for the use-cases we have there.
You can find some topics that need more love here.

@benheymink
Copy link

@michaelwittwer Have upgraded to the next branch, and after some work our side (we're also moving stuff over to AWS-SDK V3) everything appears to be working OK - nice job!

@benheymink
Copy link

@michaelwittwer I may have spoken too soon, am seeing Attempted import error: 'KeyType' is not exported from '@aws-sdk/client-dynamodb' (imported as 'KeyType'). - when building our react application, wierdly! (which relies on one of our Dynamo wrapper utilities, which in turn utilises dynamo-easy)

I saw your comment in https://github.com/shiftcode/dynamo-easy/blob/next/src/aws-sdk-v2.types.ts:
// FIXME somehow the import of KeyType from @aws-sdk/client-dynamodb does not work at runtime and imagine I am hitting the same....did you get any further on that particular issue?

@michaelwittwer
Copy link
Member Author

@benheymink did you try with the latest release 8.0.0-next.3 which includes the changes made in the code you references (aws-sdk-v2.types.ts). This solved it for me.

@benheymink
Copy link

@michaelwittwer That was it, thanks. I was still on @shiftcoders/[email protected] as per your comment above - might be worth updating?

@pascalbayer
Copy link

@michaelwittwer We've migrated most of our code to 8.0.0-next.3 without any issues so far. Is there a plan for an official release?

@pascalbayer
Copy link

@michaelwittwer Anything we can do to support a release in the near future?

@michaelwittwer michaelwittwer linked a pull request Aug 16, 2023 that will close this issue
@michaelwittwer
Copy link
Member Author

@pascalbayer We are in the process of releasing our first project using the next version to production soon. What I would like to see before merging back is documented here.
How did you implement the credential handling? Are you still using the sessionValidityEnsurer option from the config?

@nduthoit
Copy link

@michaelwittwer with AWS Lambda support for the Node.js 16 runtime being deprecated on June 12, 2024, are there plans for a dynamo-easy v8 release before then? Is there anything we could do to help?

We've been migrating our code to 8.0.0-next.3 as well without any major issue.

@michaelwittwer
Copy link
Member Author

@nduthoit Thanks for reaching out. Yes I am definitely willing to release v8 before Juni. We also have pushed a small application running in production which uses the 8.0.0-next.3 version.
You can check the v2-v3-migration file to check on outstanding tasks (probably not a complete list so feel free to contribute).

@nduthoit
Copy link

@michaelwittwer I created #422 that addresses one of the TODOs in the next branch.

@brazilianbytes
Copy link

Hi,

This is an exciting and too expected feature for me. Is there any date planned for the final version? May I help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants