Skip to content

Commit f30af43

Browse files
committed
Add password store as constructor parameter.
1 parent b1f6240 commit f30af43

File tree

2 files changed

+16
-3
lines changed

2 files changed

+16
-3
lines changed

hub/src/main/java/cloud/katta/protocols/hub/HubSession.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ public void login(final LoginCallback prompt, final CancelCallback cancel) throw
159159
try {
160160
me = new UsersResourceApi(client).apiUsersMeGet(true);
161161
log.debug("Retrieved user {}", me);
162-
final UserKeys userKeys = new UserKeysServiceImpl(this).getOrCreateUserKeys(host, me,
162+
final UserKeys userKeys = new UserKeysServiceImpl(this, keychain).getOrCreateUserKeys(host, me,
163163
new DeviceKeysServiceImpl(keychain).getOrCreateDeviceKeys(host, setup), setup);
164164
log.debug("Retrieved user keys {}", userKeys);
165165
// Ensure vaults are registered

hub/src/main/java/cloud/katta/workflows/UserKeysServiceImpl.java

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,9 @@
44

55
package cloud.katta.workflows;
66

7+
import ch.cyberduck.core.BookmarkNameProvider;
78
import ch.cyberduck.core.Host;
9+
import ch.cyberduck.core.PasswordStore;
810
import ch.cyberduck.core.PasswordStoreFactory;
911
import ch.cyberduck.core.exception.LocalAccessDeniedException;
1012

@@ -42,13 +44,24 @@ public class UserKeysServiceImpl implements UserKeysService {
4244
private final UsersResourceApi usersResourceApi;
4345
private final DeviceResourceApi deviceResourceApi;
4446

47+
private final PasswordStore store;
48+
4549
public UserKeysServiceImpl(final HubSession hubSession) {
46-
this(new UsersResourceApi(hubSession.getClient()), new DeviceResourceApi(hubSession.getClient()));
50+
this(hubSession, PasswordStoreFactory.get());
51+
}
52+
53+
public UserKeysServiceImpl(final HubSession hubSession, PasswordStore store) {
54+
this(new UsersResourceApi(hubSession.getClient()), new DeviceResourceApi(hubSession.getClient()), store);
4755
}
4856

4957
public UserKeysServiceImpl(final UsersResourceApi usersResourceApi, final DeviceResourceApi deviceResourceApi) {
58+
this(usersResourceApi, deviceResourceApi, PasswordStoreFactory.get());
59+
}
60+
61+
public UserKeysServiceImpl(final UsersResourceApi usersResourceApi, final DeviceResourceApi deviceResourceApi, PasswordStore store) {
5062
this.usersResourceApi = usersResourceApi;
5163
this.deviceResourceApi = deviceResourceApi;
64+
this.store = store;
5265
}
5366

5467
@Override
@@ -112,7 +125,7 @@ else if(validate(me)) {
112125

113126
private void save(final Host hub, final UserDto me, final String accountKey) {
114127
try {
115-
PasswordStoreFactory.get().addPassword(hub.getNickname(), me.getEmail(), accountKey);
128+
store.addPassword(BookmarkNameProvider.toString(hub), me.getEmail(), accountKey);
116129
}
117130
catch(LocalAccessDeniedException ex) {
118131
log.warn("Failure saving account key", ex);

0 commit comments

Comments
 (0)