Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize Unit Test Configuration #27

Open
shetaye opened this issue May 22, 2020 · 0 comments
Open

Standardize Unit Test Configuration #27

shetaye opened this issue May 22, 2020 · 0 comments
Assignees
@shetaye
Labels
backend Relating to backend or backend configuration

Comments

@shetaye
Copy link
Owner

shetaye commented May 22, 2020

Some of the unit tests (in particular my first, the VideoDataService unit test) have a lot of hard coded values. Hard coded values are non-configurable, so those should all become variable values tied to one const declared at the beginning of the test.

(From GitLab)
@shetaye shetaye added the backend Relating to backend or backend configuration label May 22, 2020
@shetaye shetaye added this to the Phase 2 milestone May 22, 2020
@shetaye shetaye self-assigned this May 22, 2020
@shetaye shetaye added addition Adds (or helps add) value to Swish and removed addition Adds (or helps add) value to Swish labels Jun 15, 2020
@shetaye shetaye removed this from the Phase 2 milestone Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shetaye shetaye

Labels
backend Relating to backend or backend configuration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shetaye