Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Province of City is always wrong -- Only in belgium .. #25

Open
egnappahz opened this issue May 10, 2020 · 5 comments
Open

Province of City is always wrong -- Only in belgium .. #25

egnappahz opened this issue May 10, 2020 · 5 comments

Comments

@egnappahz
Copy link

egnappahz commented May 10, 2020

Dont know if I'm doing something wrong but everything is correct except the Province of the city. Is this an issue observed by others aswel?

@egnappahz egnappahz changed the title Region of City is always wrong Province of City is always wrong May 10, 2020
@egnappahz egnappahz changed the title Province of City is always wrong Province of City is always wrong -- Only in belgium .. May 10, 2020
@egnappahz
Copy link
Author

Nevermind, only seems to be the case in Belgium so it seems. No idea why though. Guess it's kinda like our government.

@egnappahz
Copy link
Author

egnappahz commented May 10, 2020

Update: in your file geoname2fips.py you write

VLAMMS BRABANT': 'FLANDERS'

But It's supposed to be VLAAMS BRABANT.

However I cant seem to make it write a fips csv from it (absolutely clueless what parameters it is accepting) so I can't test if that fixed worked or not...

Indeed, all the flemish cities are being marked as being in flemish brabant, fixing that to flanders would indeed fix it.

Can anyone help?

@egnappahz
Copy link
Author

I found out the problem. Please take a look at following pull request:
#26

I now have all the provinces working instead of just the general region (which was wrong and fixed on a single province for all cities)

@sherpya
Copy link
Owner

sherpya commented May 11, 2020

this is fixed but I need to generate new csv, did you modified it by hand?
perhaps it needs to be converted in python module

@egnappahz
Copy link
Author

I generated it with a bash script, I couldn't get the python module to work properly. I simply took a look of the geolite's extracted location file for the used BE provnames and at the fips 10-4 province id's and then generated the csv with all the correct ids for all BE cities, and replaced it with all the wrong be entries. I'll leave it to you to decide what to do in the python code...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants