Skip to content

Latest commit

 

History

History
41 lines (23 loc) · 1.03 KB

File metadata and controls

41 lines (23 loc) · 1.03 KB

Uneven Pine Sheep

High

{actor} will {impact} {affected party}

Summary

https://github.com/sherlock-audit/2024-11-hats-protocol/blob/49de29508904e95b3cfaaf27d2e76c527429c019/hats-zodiac/src/lib/SafeManagerLib.sol#L164 The function calls _safe.execTransactionFromModule but does not check the return value. In the context of the Safe (Gnosis Safe) contract, execTransactionFromModule returns a bool indicating whether the transaction was successful. Ignoring the return value means that if the transaction fails, the failure will go unnoticed, and the function will proceed as if everything went fine. This can lead to silent failures and make debugging difficult, as the calling code assumes the transaction succeeded when it might not have.

Root Cause

No response

Internal pre-conditions

No response

External pre-conditions

No response

Attack Path

No response

Impact

No response

PoC

No response

Mitigation

Modify the function to check the return value and handle failures appropriately