We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bald Lace Cyborg
Medium
In Reputation.sol, there is no slippage control for the amount of eth recieved back, after selling particular amount of votes
https://github.com/sherlock-audit/2024-11-ethos-network-ii/blob/main/ethos/packages/contracts/contracts/ReputationMarket.sol#L495C4-L529C15
no slppage check is there in sell votes. Like there is in buy votes, in sell votes there shoudl be sliippage check too
No response
User can end up getting less eth , than he would expecting by selling tokens
amount of eth recieved should be check with the another variable which should be taken as a parameter.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Bald Lace Cyborg
Medium
there is no slippage control in function sell vote ()
Summary
In Reputation.sol, there is no slippage control for the amount of eth recieved back, after selling particular amount of votes
Root Cause
https://github.com/sherlock-audit/2024-11-ethos-network-ii/blob/main/ethos/packages/contracts/contracts/ReputationMarket.sol#L495C4-L529C15
no slppage check is there in sell votes. Like there is in buy votes, in sell votes there shoudl be sliippage check too
Internal pre-conditions
No response
External pre-conditions
No response
Attack Path
No response
Impact
User can end up getting less eth , than he would expecting by selling tokens
PoC
No response
Mitigation
amount of eth recieved should be check with the another variable which should be taken as a parameter.
The text was updated successfully, but these errors were encountered: