Skip to content
This repository has been archived by the owner on Apr 28, 2024. It is now read-only.

0x52 - Protocol is incompatible with ZkSync Era due to differences in address deviation #85

Closed
sherlock-admin opened this issue Oct 23, 2023 · 0 comments
Closed

0x52 - Protocol is incompatible with ZkSync Era due to differences in address deviation #85

sherlock-admin opened this issue Oct 23, 2023 · 0 comments
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label Medium A valid Medium severity issue Reward A payout will be made for this issue

Comments

@sherlock-admin
Copy link
Contributor

sherlock-admin commented Oct 23, 2023 •
edited
Loading

0x52

medium

Protocol is incompatible with ZkSync Era due to differences in address deviation

Summary

ZkSync utilizes a different prefix than most other EVM based chains. Instead of using "ff" it uses zksynceCreate2. This causes computePoolAddress to return incorrect pool addresses. Due to this the protocol will be broken when deployed there.

Vulnerability Detail

See summary

Impact

Contracts are nonfunctional on ZkSync

Code Snippet

ApproveSwapAndPay.sol#L271-L291

Tool used

Manual Review

Recommendation

Rewrite computePoolAddress account for this difference.

Duplicate of #104
@github-actions github-actions bot added Medium A valid Medium severity issue Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label labels Oct 26, 2023
@sherlock-admin sherlock-admin changed the title Ancient Malachite Jay - Protocol is incompatible with ZkSync Era due to differences in address deviation 0x52 - Protocol is incompatible with ZkSync Era due to differences in address deviation Oct 30, 2023
@sherlock-admin sherlock-admin added the Reward A payout will be made for this issue label Oct 30, 2023
@c4-submissions c4-submissions mentioned this issue Nov 28, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label Medium A valid Medium severity issue Reward A payout will be made for this issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sherlock-admin