Skip to content

Commit 78686f9

Browse files
committed
chore: update shelljs and drop old node support
No change to logic. This updates the ShellJS peer dependency to the latest release. This also drops support for all node versions prior to v18 to match ShellJS's version range, and adds in node v20 and v22. This modifies one unit test to work around a ShellJS bug (shelljs/shelljs#1197). Test: npm test
1 parent d9fc45a commit 78686f9

File tree

3 files changed

+7
-11
lines changed

3 files changed

+7
-11
lines changed

.github/workflows/main.yml

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,9 @@ jobs:
1010
fail-fast: false
1111
matrix:
1212
node-version:
13-
- 6
14-
- 8
15-
- 10
16-
- 12
17-
- 14
18-
- 16
1913
- 18
14+
- 20
15+
- 22
2016
os:
2117
- ubuntu-latest
2218
- macos-latest
@@ -27,4 +23,4 @@ jobs:
2723
with:
2824
node-version: ${{ matrix.node-version }}
2925
- run: npm install
30-
- run: npm run test
26+
- run: npm test

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,18 +31,18 @@
3131
"eslint-config-airbnb-base": "^13.1.0",
3232
"eslint-plugin-import": "^2.17.3",
3333
"mocha": "^5.2.0",
34-
"shelljs": "^0.8.5",
34+
"shelljs": "^0.9.1",
3535
"shelljs-changelog": "^0.2.6",
3636
"shelljs-release": "^0.5.1",
3737
"should": "^13.2.3"
3838
},
3939
"peerDependencies": {
40-
"shelljs": "^0.8.5"
40+
"shelljs": "^0.9.1"
4141
},
4242
"dependencies": {
4343
"opener": "^1.4.1"
4444
},
4545
"engines": {
46-
"node": ">=6"
46+
"node": ">=18"
4747
}
4848
}

test/test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ describe('plugin-open', function () {
124124
* Plugins can easily take advantage of ShellJS's built-in glob expansion.
125125
* This is indicated by the globStart option
126126
*/
127-
var ret = shell.open('te?t/*st.js');
127+
var ret = shell.open('te*/t?st.js');
128128
ret.code.should.equal(0);
129129
ret.stdout.should.equal('');
130130
assert.ok(!ret.stderr);

0 commit comments

Comments
 (0)