Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on the Authentication #3

Open
3 tasks
shazm12 opened this issue Sep 29, 2022 · 9 comments
Open
3 tasks

Work on the Authentication #3

shazm12 opened this issue Sep 29, 2022 · 9 comments
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed

Comments

@shazm12
Copy link
Owner

shazm12 commented Sep 29, 2022

I need someone to work on the authentication logic of my web app. Currently I am just validating the data given using simple checks and then encrypting my passwords before storing to the DB. I am thinking to use JWT Tokens or passport.js for better and secure authentication flow. What are your takes on this? Can you implement this system?
Will check the following points

  • Secure and working Authentication flow.
  • Libraries and components used
  • How well you maintain code

Rest is up to your creativity!

@shazm12 shazm12 added enhancement New feature or request help wanted Extra attention is needed hacktoberfest labels Sep 29, 2022
@meetagrawal09
Copy link
Contributor

meetagrawal09 commented Sep 30, 2022

Hey @shazm12, I would like to work on this. Can you assign this to me
I am planning to do it using JWT authentication
The idea here will be that all the APIs will be secured and will be accessible using the token
My implementation includes creating a token generator and further a middleware to validate the token

@shazm12
Copy link
Owner Author

shazm12 commented Sep 30, 2022

sounds amazing @meetagrawal09 I am assigning this issue to you.

@meetagrawal09
Copy link
Contributor

meetagrawal09 commented Sep 30, 2022

@shazm12,
You have not included a .gitignore file, anyone who is to clone the repository also gets in node_modules alongside
Also there are some small typos in the code which cause the build to fail initially

@meetagrawal09
Copy link
Contributor

meetagrawal09 commented Sep 30, 2022

@shazm12, can you please explain me the need of a package.json outside client and server folders. Because I see that your package.json in the root directory has some UI libraries included like material-ui which could have been put up inside of client directory

@shazm12
Copy link
Owner Author

shazm12 commented Sep 30, 2022

that's not

@shazm12, You have not included a .gitignore file, anyone who is to clone the repository also gets in node_modules alongside Also there are some small typos in the code which cause the build to fail initially

ohh i thought i had included the .gitignore file so sorry for this, yes the proposed changes makes sense please do and make a PR i ll label them too as contribution for the hacktoberfest. Thanks!

@shazm12
Copy link
Owner Author

shazm12 commented Sep 30, 2022

@shazm12, can you please explain me the need of a package.json outside client and server folders. Because I see that your package.json in the root directory has some UI libraries included like material-ui which could have been put up inside of client directory

There's no need for it but you might get error in client side the other team mate with me had screwed a little bit with project but mostly without the mentioned package.json file it will work, please check n tell me okay thanks!

@shazm12
Copy link
Owner Author

shazm12 commented Sep 30, 2022

the material-ui was removed from the final version so it should still work

@meetagrawal09
Copy link
Contributor

@shazm12 , raised a PR with all the corrections and some additional security measures
#5

@shazm12
Copy link
Owner Author

shazm12 commented Sep 30, 2022

cool will check it

@meetagrawal09 meetagrawal09 removed their assignment Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants