Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloads: disable parallel downloads unless connection is fast #664

Open
ell1e opened this issue Mar 2, 2025 · 4 comments · May be fixed by #670
Open

Downloads: disable parallel downloads unless connection is fast #664

ell1e opened this issue Mar 2, 2025 · 4 comments · May be fixed by #670

Comments

@ell1e
Copy link

ell1e commented Mar 2, 2025

I've noticed minigalaxy seems to always download 3+ parts at once. This isn't a good idea on a slow connection and will only make everything slower and cause more dropouts. Therefore, I suggest this should only be done if the connection speed exceeds a certain threshold. Not sure where that ideally would be, but I'm guessing something like 10mbit/s as an absolute minimum.

Affected minigalaxy version: 1.3.2 (latest flatpak stable)

Affected operating system: postmarketOS 24.12 based on Alpine 3.21.3

@sharkwouter
Copy link
Owner

Thanks for this report. Maybe making the amount of download threads configurable would be a good solution for this.

@ell1e
Copy link
Author

ell1e commented Mar 2, 2025

Most users probably won't think to configure it, so the default behavior might still be relevant.

@sharkwouter
Copy link
Owner

Fair point. I do think making it based on download speed would be harder to implement, but not impossible.

@GB609
Copy link
Collaborator

GB609 commented Mar 2, 2025

I'd just give an option and introduce a way to dynamically change it in the downloads ui. The config option could then just use the current constants as default fallbacks.
Maybe just a small numbers dropdown in the 'active downloads' section.

@GB609 GB609 linked a pull request Mar 7, 2025 that will close this issue
1 task
@GB609 GB609 linked a pull request Mar 7, 2025 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants