Getting supported languages with innoextract can fail silently

[sharkwouter]

The return code of the application is never checked and neither is the stderr:

minigalaxy/minigalaxy/installer.py

Lines 376 to 395 in a2c04d3

	def lang_install(installer: str, language: str):
	languages = []
	arg = ""
	process = subprocess.Popen(["innoextract", installer, "--list-languages"], stdout=subprocess.PIPE, stderr=subprocess.PIPE)
	stdout, stderr = process.communicate()
	output = stdout.decode("utf-8")
	for line in output.split('\n'):
	if not line.startswith(' -'):
	continue
	languages.append(line[3:])
	for lang in languages:
	if "-" in lang: # lang must be like "en-US" only.
	if language == lang[0:2]:
	arg = "--language={}".format(lang)
	break
	else:
	arg = "--language=en-US"
	break
	return arg

[GB609]

I'll include this in my wine rework branch, since i have to touch this part of the code anyway to fix issues with innoextract.

[sharkwouter]

I think it would be better to have this in a separate PR.

[GB609]

OK. I'll leave it out. Might need another addition afterwards to get the automatic language selection during installation to work.

[sharkwouter]

Yeah, that is true, but it would be nice to merge the current MR as soon as possible. For that we need to keep it focused. Smaller PRs are much easier and faster to review.

[GB609]

I've only got 2 more failing test cases atm and these are related to innoextract and lang_install.

[sharkwouter]

Ah okay, let me know if you need any help.