Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider refactor to cast between snapshot and doc like sharedb-mongo #4

Open
ericyhwang opened this issue Feb 27, 2018 · 0 comments
Open

Comments

@ericyhwang
Copy link
Contributor

Filing @nateps's comment from a PR to keep track of it:

At first glance, I think it might be better to cast the format in which we store the docs rather than cast the query. This is how sharedb-mongo works, so I think it would be easier to make it more consistent. We might also be able to share code by creating another module that this and sharedb-mongo depend on or by at least copy-pasting and cross referencing the code.

Switching to snapshot/doc casting may make it easier to have filtering be fully consistent with sharedb-mongo.

In sharedb-mongo, query filters on special Share properties look like {'_v': {$lte: 10}}. #3 added sharedb-mingo-memory support for filtering on all such special properties except Share metadata. An example of such a metadata query is {'_m.mtime': {$gte: 100}}. I added a currently-skipped test for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant