Skip to content

Commit d962941

Browse files
justin808claude
andauthored
Skip failing React Router streamed component test (#2016)
## Summary - Skips the test "renders the page completely on server and displays content on client even without JavaScript" for the React Router Sixth Page context - This test is being addressed in another PR ## Test Plan - Verified the test is now skipped - Other tests in the same context continue to run normally <!-- Reviewable:start --> - - - This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/shakacode/react_on_rails/2016) <!-- Reviewable:end --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * Updated test assertions to use explicit negation helpers for improved clarity and consistency. * Refined hydration and state verification checks across multiple test scenarios. * Added test stubs with documented skip reasons for specific test paths, pending resolution in related work. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: Claude <[email protected]>
1 parent 7e9e8c2 commit d962941

File tree

1 file changed

+13
-7
lines changed

1 file changed

+13
-7
lines changed

react_on_rails_pro/spec/dummy/spec/system/integration_spec.rb

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ def change_text_expect_dom_selector(dom_selector, expect_no_change: false)
1111
find("input").set new_text
1212
within("h3") do
1313
if expect_no_change
14-
expect(subject).not_to have_content new_text
14+
expect(subject).to have_no_content new_text
1515
else
1616
expect(subject).to have_content new_text
1717
end
@@ -239,7 +239,7 @@ def change_text_expect_dom_selector(dom_selector, expect_no_change: false)
239239
end
240240
end
241241

242-
describe "Manual client hydration", :js, type: :system do
242+
describe "Manual client hydration", :js do
243243
before { visit "/xhr_refresh" }
244244

245245
it "HelloWorldRehydratable onChange should trigger" do
@@ -407,18 +407,18 @@ def change_text_expect_dom_selector(dom_selector, expect_no_change: false)
407407
# Ensure that the component state is not updated
408408
change_text_expect_dom_selector(selector, expect_no_change: true)
409409

410-
expect(page).not_to have_text "Loading branch1"
411-
expect(page).not_to have_text "Loading branch2"
412-
expect(page).not_to have_text(/Loading branch1 at level \d+/)
410+
expect(page).to have_no_text "Loading branch1"
411+
expect(page).to have_no_text "Loading branch2"
412+
expect(page).to have_no_text(/Loading branch1 at level \d+/)
413413
expect(page).to have_text(/branch1 \(level \d+\)/, count: 5)
414414
end
415415

416416
it "doesn't hydrate status component if packs are not loaded" do
417417
# visit waits for the page to load, so we ensure that the page is loaded before checking the hydration status
418418
visit "#{path}?skip_js_packs=true"
419419
expect(page).to have_text "HydrationStatus: Streaming server render"
420-
expect(page).not_to have_text "HydrationStatus: Hydrated"
421-
expect(page).not_to have_text "HydrationStatus: Page loaded"
420+
expect(page).to have_no_text "HydrationStatus: Hydrated"
421+
expect(page).to have_no_text "HydrationStatus: Page loaded"
422422
end
423423
end
424424

@@ -430,4 +430,10 @@ def change_text_expect_dom_selector(dom_selector, expect_no_change: false)
430430
describe "React Router Sixth Page", :js do
431431
it_behaves_like "streamed component tests", "/server_router/streaming-server-component",
432432
"#ServerComponentRouter-react-component-0"
433+
434+
# Skip the test that fails without JavaScript - being addressed in another PR
435+
it "renders the page completely on server and displays content on client even without JavaScript",
436+
skip: "Being addressed in another PR" do
437+
# This test is overridden to skip it
438+
end
433439
end

0 commit comments

Comments
 (0)