Comprehensive rewrite of React on Rails Pro README (#1987)

## Summary

Complete rewrite of the React on Rails Pro README.md to fix all
identified issues and properly position it as a commercial product.

## Changes

### ✅ Fixed All Critical Issues
- ❌ **Removed fake CircleCI badge** - Replaced with real GitHub Actions
badges
- ✅ **Added comprehensive licensing information** - Clear explanation of
free vs. commercial licenses
- ✅ **Added prerequisites section** - Requirements and compatibility
matrix
- ✅ **Improved installation instructions** - Quick start guide for
public monorepo installation

### 📋 New Sections Added
1. **What is React on Rails Pro?** - Clear explanation and relationship
to open source
2. **License & Pricing** - Free for non-commercial, paid for production
3. **Why Use Pro?** - Performance case study (Popmenu) and use cases
4. **Pro vs. Open Source** - Feature comparison table
5. **Requirements** - Prerequisites and compatibility matrix
6. **Quick Start** - 5-minute getting started guide
7. **Key Features** - Expanded with code examples and benefits
8. **Documentation** - Organized by category with descriptions
9. **Examples** - Pro dummy app walkthrough
10. **Support & Contact** - Multiple ways to get help
11. **FAQ** - Licensing, technical, and getting started questions

### 🎯 Key Improvements

**Structure & Navigation**
- Added comprehensive table of contents
- Organized into logical sections
- Clear hierarchy and flow

**Licensing**
- Prominent explanation that it's free for non-commercial use
- Instructions to get FREE 3-month license in 30 seconds
- Links to LICENSE_SETUP.md for detailed setup
- Explained difference between evaluation and commercial licenses

**Installation**
- Quick start (5 minutes)
- Instructions for installing from public monorepo
- No more confusing private GitHub packages references
- Step-by-step verification

**Features**
- Each feature has code examples
- Benefits clearly listed
- Links to detailed documentation
- Real-world performance numbers

**Marketing/Positioning**
- Positioned as commercial product with free option
- Real-world case study (Popmenu: 73% faster, 20-25% cost reduction)
- Clear value proposition
- Professional services information

### 📊 Addresses All Issues

This PR fixes all 20+ issues documented in
`react_on_rails_pro_readme_issues.md`:

1. ✅ Removed CircleCI badge (replaced with real GitHub Actions badges)
2. ✅ Added licensing information
3. ✅ Added prerequisites/requirements section
4. ✅ Improved installation instructions
5. ✅ Added "What is React on Rails Pro" section
6. ✅ Consistent tone for commercial product
7. ✅ Added proper badges
8. ✅ Fixed "Getting Started" confusion
9. ✅ Added support/contact information
10. ✅ Added upgrade guide references
11. ✅ Added "Why Use Pro?" section
12. ✅ Added quick start guide
13. ✅ Added examples/use cases
14. ✅ Added compatibility table
15. ✅ Added FAQ section
16. ✅ Improved documentation structure
17. ✅ Expanded feature descriptions
18. ✅ Prominently linked LICENSE_SETUP.md
19. ✅ Uses real GitHub Actions workflows for badges

### 📝 Documentation Included

Created `react_on_rails_pro_readme_issues.md` documenting all identified
issues for reference.

## Testing

- ✅ All file references verified to exist
- ✅ Formatted with Prettier (via pre-commit hooks)
- ✅ All markdown properly structured
- ✅ Links point to correct locations

## Impact

This README now:
- ✅ Clearly explains what Pro is and why you'd use it
- ✅ Makes it easy to get started (5-minute quick start)
- ✅ Positions Pro as a commercial product with free option
- ✅ Answers common questions upfront (FAQ)
- ✅ Provides clear path from evaluation to production
- ✅ Uses real CI badges instead of fake ones
- ✅ Links to comprehensive licensing documentation

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

<!-- Reviewable:start -->
- - -
This change is [<img src="https://reviewable.io/review_button.svg"
height="34" align="absmiddle"
alt="Reviewable"/>](https://reviewable.io/reviews/shakacode/react_on_rails/1987)
<!-- Reviewable:end -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Documentation**
* README reworked into a marketing/documentation hub with sections like
What is Pro, License & Pricing, Key Features, Getting Started, Examples,
and Support.
* Technical onboarding condensed; detailed feature guides moved into
named feature sections and external docs/examples.
* Added licensing flow, pricing overview, licensing FAQ, case study
references, and updated support/contact and branding information.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Claude <[email protected]>

Author: justin808