Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to tailwindcss #553

Merged
merged 40 commits into from
Oct 17, 2023
Merged

Migrate to tailwindcss #553

merged 40 commits into from
Oct 17, 2023

Conversation

ahangarha
Copy link
Contributor

@ahangarha ahangarha commented Sep 9, 2023 •
edited
Loading

In this PR:

  • Bootstrap is completely removed from the project.
  • For transitions, we still use CSS modules and Sass for:
    • Lesser changes in the PR
    • Good to have such demonstrations in this project
  • I have used the typography plugin for Tailwind CSS for easier styling.

This PR, resolves the flashing issue as well (with production build)

Closes #526
Closes #545

This change is Reviewable

ahangarha
ahangarha commented Sep 10, 2023
View reviewed changes
spec/stimulus/turbo_spec.rb
@@ -52,6 +52,7 @@
fill_in author_field, with: comment.author
fill_in text_field, with: comment.text
click_button("Post")
sleep(1)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without forcing some delay, I hardly could get this test pass locally.

@ahangarha ahangarha force-pushed the migrate-to-tailwindcss branch 2 times, most recently from 9200c1a to ada3549 Compare September 10, 2023 18:56
@ahangarha ahangarha changed the title WIP - Migrate to tailwindcss Migrate to tailwindcss Sep 12, 2023
@ahangarha ahangarha marked this pull request as ready for review September 12, 2023 12:15
Judahmeek
Judahmeek requested changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@Judahmeek Judahmeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks really good.

I've just got one small change to request: please remove sass-resources-loader if possible.

package.json Show resolved Hide resolved
@ahangarha
Copy link
Contributor Author

@justin808 I think 384e1c3 satisfies your request regarding keeping sass-resources-loader in the project.

@justin808 justin808 merged commit 2c8073b into master Oct 17, 2023
3 checks passed
@justin808 justin808 deleted the migrate-to-tailwindcss branch October 17, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Judahmeek Judahmeek Awaiting requested review from Judahmeek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolve flashing while loading the page Convert to Tailwind
3 participants
@ahangarha @Judahmeek @justin808