-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE]: Nightly clean review apps and images #603
Conversation
Caution Review failedThe pull request is closed. WalkthroughThe changes introduce new configuration parameters for image retention and stale application management in the Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Hi 👋 To deploy a review app, please comment |
/deploy-review-app |
We started working on your review-app deployment. You can track progress in the |
/deploy-review-app |
We started working on your review-app deployment. You can track progress in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- .controlplane/controlplane.yml (1 hunks)
- .github/actions/common-ruby-cpl-setup/action.yml (1 hunks)
- .github/actions/deploy-to-control-plane/action.yml (1 hunks)
- .github/workflows/nightly-remove-stale-review-apps.yml (1 hunks)
Files skipped from review due to trivial changes (1)
- .controlplane/controlplane.yml
Additional comments not posted (7)
.github/workflows/nightly-remove-stale-review-apps.yml (3)
1-5
: LGTM!The file header and schedule section are correctly defined.
The code changes are approved.
7-9
: LGTM!The jobs section is correctly defined.
The code changes are approved.
11-24
: LGTM!The steps section is correctly defined and uses appropriate actions and commands.
The code changes are approved.
.github/actions/common-ruby-cpl-setup/action.yml (3)
1-5
: LGTM!The file header and description section are clear and descriptive.
The code changes are approved.
6-8
: LGTM!The runs section is correctly defined.
The code changes are approved.
9-25
: LGTM!The steps section is correctly defined and uses appropriate actions and commands.
The code changes are approved.
.github/actions/deploy-to-control-plane/action.yml (1)
19-20
: LGTM!The consolidation of setup steps into a single step improves maintainability and reduces redundancy.
The code changes are approved.
@rameziophobia thanks. looks good. |
Note: NOT TESTED YET
This change is
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Improvements