Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example of rescript to this tutorial #442

Closed
justin808 opened this issue Aug 9, 2018 · 15 comments
Closed

Add example of rescript to this tutorial #442

justin808 opened this issue Aug 9, 2018 · 15 comments
Assignees
@Yassa-hue
Labels
enhancement

Comments

@justin808
Copy link
Member

justin808 commented Aug 9, 2018 •
edited
Loading

See https://github.com/shakacode/bs-react-on-rails.

I'd like to see another tab that shows Reason ML.

image
@coderhs
Copy link

coderhs commented Jan 4, 2019

I will give it a shot. Just letting you know that I am working on it.

@coderhs coderhs mentioned this issue Jan 5, 2019
Closed
@justin808
Copy link
Member Author

@coderhs Any update?

@Sirbuland
Copy link

Sirbuland commented Feb 22, 2019 •
edited
Loading

Hi @justin808 !
I would like to grab this issue.

@Sirbuland
Copy link

Sirbuland commented Feb 22, 2019 •
edited
Loading

@justin808 added a new tab. Please provide me permissions to push changes. Thanks!

screenshot 2019-02-22 at 7 04 38 pm

@justin808
Copy link
Member Author

@Sirbuland just push a PR.

@shahidjutt72
Copy link

@justin808 Could u please give me access. I have added the 'Reason ML' link added on top navigation bar pointing to https://reasonml.github.io. I want to create pull request.
Thanks

@justin808
Copy link
Member Author

@Sirbuland @shahidjutt72 The way to do this is to fork and submit a PR.

And @Sirbuland, the link would point to a demo of using Reason with the rest of the code, not to the Reason docs.

@acald-creator
Copy link

Hello! Is anyone working this, @justin808 ?

@justin808
Copy link
Member Author

@pullmana8, nope not right now! Want to give it a shot?

@acald-creator
Copy link

@justin808 Yes I would love to.

@hansleykowlessur hansleykowlessur mentioned this issue Feb 11, 2021
Closed
@hansleykowlessur
Copy link

hansleykowlessur commented Feb 11, 2021 •
edited
Loading

Hi @justin808, I grabbed the issue and created a pull request #487. Please let me know if it is working. Thank you.

Reason ML Navigation Bar

Reason ML Nav Bar

@enterstudio enterstudio mentioned this issue Nov 5, 2022
Open
@enterstudio enterstudio mentioned this issue Dec 26, 2022
Open
@ahangarha
Copy link
Contributor

@justin808
Do you still want this? If so, what was the issue with the PR?

@justin808
Copy link
Member Author

Nice to have example of ReScript here. However, we need to check @alex35mil first.

@ahangarha
Copy link
Contributor

I just want to make it clear. We want a page demonstrating components using ReScript.
If I am right, there is another question. I know ReactOnRails supports ReScript. Does ReactRails support ReScript? If not, this feature conflicts with #503

@justin808 justin808 changed the title Add example of bucklescript to this tutorial Add example of rescript to this tutorial Aug 11, 2023
Yassa-hue added a commit that referenced this issue Aug 23, 2023
@Yassa-hue
Add rescript example (#442)
2781900 
* Add rescript build configurations

* Create rescript page components

* Add rescript deps
Yassa-hue added a commit that referenced this issue Oct 18, 2023
@Yassa-hue
Add rescript example (#442)
a4c904d 
* Add rescript build configurations

* Create rescript page components

* Add rescript deps
Yassa-hue added a commit that referenced this issue Nov 3, 2023
@Yassa-hue
Add rescript example (#442)
075856e 
* Add rescript build configurations

* Create rescript page components

* Add rescript deps
justin808 pushed a commit that referenced this issue Nov 17, 2023
@Yassa-hue
Add rescript example (#442) (#552)
764a299 
* Add rescript example (#442)

* Add rescript build configurations

* Create rescript page components

* Add rescript deps

* Solve render comments issue

* Refactor css transaction components

React Hooks shouldn't be used in loops or if statement.

* Ignore the rescript output js files from lint

The rescript output js files from lint because it doesn't follow the lint rules.

* Apply review requested changes

* Remove unused tag

* Add ROR binding

* Apply review requested changes

* remove action js file

* Remove .mjs files

* Compile rescript files before running js tests

* Build recript files before test

* minor change

* remove react-on-rails binding

* migrate to tailwind

* remove bs.mjs files

* remove unused scss files

* fix rescript spec tests

* build rescript before test

* refactor rescript src

* fix add commit fail bug

* refactor the types

* format rescript files

* remove the types files

* update error rescript page state design

* refactor switch statements

* move store comment state to the form component

* format rescript

* rename the saving state

* empty commit
@ahangarha
Copy link
Contributor

Added in #552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yassa-hue Yassa-hue

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@coderhs @justin808 @shahidjutt72 @ahangarha @acald-creator @Sirbuland @hansleykowlessur @Yassa-hue