feat: Add getCurrentPlaybackInfo method to Player #6825
+89
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Incremental code coverage: 36.96% |
avelad
approved these changes
Jun 14, 2024
caridley
reviewed
Jun 14, 2024
| * @return {!shaka.extern.PlaybackInfo} | ||
| */ | ||
| getCurrentPlaybackInfo() { | ||
| const variant = this.streamingEngine_.getCurrentVariant(); |
There was a problem hiding this comment.
This is going to get the variant that is currently being fetched, which may be different from the variant that is being used at the playhead.
There was a problem hiding this comment.
We don't currently track that. To solve your problem, it seems like we would need to do so first.
If we did, we would have to be careful not to create memory leaks, e.g. a timeline that maps time ranges to variants, but variant objects get recreated on every manifest refresh, and the timeline still holds references to old ones that now can't be GC'd....
joeyparrish
requested changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6725