-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to get the subtitle to get on top of the play control bar when it is shown? #6672
Comments
Doing further research and comparing, for some reason in my setup the |
I am using:
But the text container is not created. |
Good and bad news. First the good, I fixed the problem on the text container not being created appropriately; documentation is not OK I guess @avelad To make it work, you must set the videoContainer before calling the attach method.
The documentation states to do the setVideoContainer before the load, but it has to be done before the attach. However, the problem now is that it doesn't go up when the controls are shown. But it does not in the player i have with the fixed I quoted. |
Finally found the whole problem - I think we need to work on how to fix this. As the only way to get the text container created appropriately is before the attach method, at that time the UI does not exist. So the I am not really sure what approach we should work on, @avelad @joeyparrish , if we should fix the setVideoContainer method so that it would work if we call it before the load() in order to have the UI set up appropriately before, or if we should keep as it is now, update the documentation and tutorials to make it clear that it has to be called before the attach method and then fix the UI so that it is added before the text-container. I hope we can benefit from your broad expertise here. Mariano. |
@MarianoFacundoArch I updated the documentation about attach process |
@MarianoFacundoArch Does this answer all your questions? If so, would you please close the issue? |
I see this when loading subtitles with the latest shaka version (4.8.5).
I am trying to look at what might be causing this, but I do not have any clues about how to get the appropriate behavior, as I am doing nothing strange other than adding the text tracks and loading the Shaka player UI.
Could you please guide me on where I should be observing the expected behavior of the subtitles?
Any help would be greatly appreciated!
Thanks
The text was updated successfully, but these errors were encountered: