Macro DISALLOW_COPY_AND_ASSIGN include/file.h #1406
Comments
zaki699
changed the title
|
I think you are correct. This is a violation that would break header installation for the shared library build. macros/classes.h should be moved to the public headers. |
|
Yes that’s a bit of a problem on my side as I am currently using libpackager. I have to manually copy the file macros/classes into include which is not great. Should I create a pull request to add macros/classes to the public include ? |
|
Yes, please! |
|
There is a CMake target that is meant to catch errors like these. I'm going to figure out why it didn't. |
joeyparrish
added
type: bug
|
Commands for configuring shared libs and building the link test, which compiles a simple application with libpackager and the public headers: cmake -S . -B build/ -DCMAKE_BUILD_TYPE=Debug -G Ninja -DBUILD_SHARED_LIBS=ON
cmake --build build/ --parallel -- packager_link_testIt works. However, the main file includes only packager.h, which includes all the other header files except file.h. If we add file.h to packager.h, the build fails. |
include/file.h is breaking header installation for the shared library build. macros/classes.h must be included to the public headers. Closes #1406 Co-authored-by: Zaki Ahmed <[email protected]> Co-authored-by: Joey Parrish <[email protected]>
Hi Everyone,
is that normal that include/file.h contains this line:
From the README
These are the public headers for libpackager. They can only reference other
public headers or standard system headers. They cannot reference internal
headers (in
packager/...) or third-party dependency headers (inpackager/third_party/...).Is that a mistake or I am missing something ?
Regards,
The text was updated successfully, but these errors were encountered: