Skip to content

Commit 0857653

Browse files
authored
ci: Fix workflow events (#1446)
This was found by auditing workflows based on research published here: https://github.com/joeyparrish/workflow-cheat-sheet The research was prompted by a workflow bug in Shaka Streamer
1 parent cca6cc0 commit 0857653

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/workflows/pr.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ on:
2626
# old one. If a PR is updated and a new test run is started, the old test run
2727
# will be cancelled automatically to conserve resources.
2828
concurrency:
29-
group: ${{ github.workflow }}-${{ inputs.ref || github.ref }}
29+
group: ${{ github.workflow }}-${{ github.event.number || inputs.ref }}
3030
cancel-in-progress: true
3131

3232
jobs:

.github/workflows/release-please.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ jobs:
8282
if: needs.release.outputs.release_created && needs.compute.outputs.latest
8383
uses: ./.github/workflows/publish-docs.yaml
8484
with:
85-
ref: ${{ github.ref }}
85+
ref: refs/tags/${{ needs.release.outputs.tag_name }}
8686

8787
# Publish official docker image
8888
docker:
@@ -105,7 +105,7 @@ jobs:
105105
if: needs.release.outputs.release_created
106106
uses: ./.github/workflows/build.yaml
107107
with:
108-
ref: ${{ github.ref }}
108+
ref: refs/tags/${{ needs.release.outputs.tag_name }}
109109
self_hosted: ${{ needs.settings.outputs.self_hosted != '' }}
110110
debug: ${{ needs.settings.outputs.debug != '' }}
111111

0 commit comments

Comments
 (0)