Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with a more recent version of pandoc ( > 2.11 ) #190

Open
ggrochow opened this issue Mar 18, 2023 · 1 comment · May be fixed by #208
Open

Build with a more recent version of pandoc ( > 2.11 ) #190

ggrochow opened this issue Mar 18, 2023 · 1 comment · May be fixed by #208

Comments

@ggrochow
Copy link
Contributor

The version of pandoc being used by the CI to build the site, has a quite annoying accessibility issue surrounding code-blocks.

Every line in a codeblock has an <a> tags with aria-hidden="true" on it, linking to an id element which is accessible via tab navigation through the site, causing anyone using that style of navigation to have to press tab to navigate past a hidden element for each line of code in any given example. further reading on the issue

This an example of the offending HTML from the website produced by pandoc 2.9.2.1 in your CI image

This issue has been fixed by later versions of pandoc by including the tabindex="-1" attribute on these a tags. I believe the fix lands in pandoc 2.11. pandoc release notes for 2.11 The fix is updating the skylight engine, where the actual fix occurred in their version 0.10. skylighting 0.10 changelog

This is what pandoc 2.17.1.1 produced for me when building it locally. image

@weiznich
Copy link
Collaborator

I'm happy to accept a PR for this.

@moyeah moyeah linked a pull request Sep 29, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants