Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cd workflow and post initial package #43

Open
jeromekelleher opened this issue Aug 6, 2024 · 8 comments
Open

Add cd workflow and post initial package #43

jeromekelleher opened this issue Aug 6, 2024 · 8 comments

Comments

@jeromekelleher
Copy link
Contributor

I think we can post an initial 0.0.1 package to pypi to make this easier to try out/squat on the name.

Hopefully we can copy the cd workflow from bio2zarr and plug in to that?

Although it might be easier if I set up the initial pypi package first manually, and then we get the cd workflow going for subsequent releases?

@jeromekelleher
Copy link
Contributor Author

Ready to go, let's ship it!

@jeromekelleher
Copy link
Contributor Author

I've tagged an initial package 0.0.1a1 but had some problems with the CD here. Looks like something to do with tokens?

@benjeffery
Copy link
Contributor

The actual error is
Can't have direct dependency: bio2zarr@git+https://github.com/sgkit-dev/bio2zarr.git ; extra == "dev". See https://packaging.python.org/specifications/core-metadata for more information.

@tomwhite
Copy link
Contributor

So we should change to depend on a released bio2zarr. I've just realised that bio2zarr has a direct (github) dependency on hypothesis-vcf, which doesn't have any releases. So I think I need to release that first to unblock a release of bio2zarr then vcztools. I'll do a hypothesis-vcf release later in the week.

@jeromekelleher
Copy link
Contributor Author

What's the bio2zarr dependency for here? Would be nice to keep these separated, or perhaps make the dependency go the other direction? (I can imagine vcztools forming a useful place to keep core functionality useful across the ecosystem, e.g. efficient iteration over variants as discussed in #112).

@benjeffery
Copy link
Contributor

I think it can be removed as a dependency as currently it is in [project.optional-dependencies] and the only references in the repo are in tests. Suggest moving dev deps to a separate requirements file that isn't inspected by PyPI.

@jeromekelleher
Copy link
Contributor Author

Well it's nice having all the deps in one place all right, it does get messy have loads of requirements files. I'm guessing we just need to ship a version of bio2zarr, so then the dev deps can be one something released.

@tomwhite
Copy link
Contributor

The bio2zarr dependency is just for testing, which I think is correct.

I've now released hypothesis-vcf to PyPI, and created a PR to use it in bio2zarr.

Then (next week?) we can release bio2zarr, and then vcztools after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants