Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcf_writer emitting incorrect missing values for INFO fields #1196

Closed
jeromekelleher opened this issue Feb 15, 2024 · 0 comments
Closed

vcf_writer emitting incorrect missing values for INFO fields #1196

jeromekelleher opened this issue Feb 15, 2024 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@jeromekelleher
Copy link
Collaborator

After correcting the missing-fill-bug (#1192) in #1190, the vcf_writer round trip tests fail. We get:

$ python3 -m pytest -vs sgkit/tests/io/vcf/test_vcf_roundtrip.py::test_vcf_to_zarr_to_vcf__real_files[sample.vcf.gz-None-True]
                ), f"INFO keys not equal for variants\n{v1}{v2}"
E               AssertionError: INFO keys not equal for variants
E                 19    111     .       A       C       9.6     .       .       GT:HQ   0|0:10,15       0|0:10,10       0/1:3,3
E                 19    111     .       A       C       9.6     .       NS=.;AN=.;AC=.,.;DP=.;AF=.,.;AA=.       GT:GQ:DP:HQ     0|0:.:.:10,15   0|0:.:.:10,10   0/1:.:.:3,3
E                 
E               assert dict_keys([]) == dict_keys(['N..., 'AF', 'AA'])
E                 Full diff:
E                 - dict_keys(['NS', 'AN', 'AC', 'DP', 'AF', 'AA'])
E                 + dict_keys([])

It looks like the code is depending on having a FILL value when skipping a VCF key INFO key rather than MISSING?

@jeromekelleher jeromekelleher added the bug Something isn't working label Feb 15, 2024
@jeromekelleher jeromekelleher added this to the 0.8.0 release milestone Feb 15, 2024
jeromekelleher added a commit to jeromekelleher/sgkit that referenced this issue Feb 15, 2024
jeromekelleher added a commit to jeromekelleher/sgkit that referenced this issue Feb 15, 2024
jeromekelleher added a commit to jeromekelleher/sgkit that referenced this issue Feb 16, 2024
jeromekelleher added a commit to jeromekelleher/sgkit that referenced this issue Feb 16, 2024
jeromekelleher added a commit to jeromekelleher/sgkit that referenced this issue Feb 16, 2024
jeromekelleher added a commit to jeromekelleher/sgkit that referenced this issue Feb 16, 2024
jeromekelleher added a commit to jeromekelleher/sgkit that referenced this issue Mar 5, 2024
jeromekelleher added a commit to jeromekelleher/sgkit that referenced this issue Mar 5, 2024
mergify bot pushed a commit that referenced this issue Mar 5, 2024
@mergify mergify bot closed this as completed in 42816b6 Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant