Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPv4 host slider value display can be wrong, depending on v4 prefix length #34

Open
sfreemire opened this issue Jun 4, 2024 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@sfreemire
Copy link
Owner

sfreemire commented Jun 4, 2024

IPv4 Host slider values wrong when BMR IPv4 pfx len exceeds 24 and network address is greater than 0.
Also possibly when IPv4 pfx len < 24 and host value exceeds 255.
Example:
IPv4 Pfx Length First IPv4 host
98.161.92.0 /28 0
98.161.92.16. /28. 16 --------- in this case, IPv4 Host slider shows "0" and moving to "1" increments "CE IP" to 17.

Initial slider value logic needs to account for smaller IPv4 CIDRs.

@sfreemire sfreemire added the bug Something isn't working label Jun 4, 2024
@sfreemire
Copy link
Owner Author

The slider doesn't inherit the full last octet of the address when the mask is > 24.
This is because the host is still the 0th host of the current block.
Also, the slider can't inherit a host that is greater than 8 bits and display it in dotted notation. It would have to display the host in decimal format, which wouldn't make sense to a user.
The slider may need to be abandoned for "plus" and "minus" buttons like the "Source Port Index" has. That way they will be able to increment and decrement through the entire range of hosts without having to also display the host address.

@sfreemire sfreemire added the enhancement New feature or request label Jun 12, 2024
@sfreemire sfreemire changed the title IPv4 Host slider values wrong when IPv4 pfx len > 24 and net addr > 0 Possible v4 host slider value display wrong, depending on v4 prefix length Jun 12, 2024
@sfreemire sfreemire changed the title Possible v4 host slider value display wrong, depending on v4 prefix length IPv4 host slider value display can be wrong, depending on v4 prefix length Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant