Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revenue is not comma separated according to locale #328

Open
Alferguson opened this issue Jul 7, 2021 · 0 comments
Open

Revenue is not comma separated according to locale #328

Alferguson opened this issue Jul 7, 2021 · 0 comments

Comments

@Alferguson
Copy link

The revenue amount is not comma separated. A simple fix for this is to use Javascript's toLocaleString method for the Number type which will handle both locales that use commas and do not use commas for numbers. I already created a separate branch for it but I cannot create a pull request as I don't have access. Can I be given access to the repo so I can submit the pr? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant