Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

364 ticket, changed subgoal to benchmark #381

Merged
merged 11 commits into from
Nov 2, 2024
Merged

364 ticket, changed subgoal to benchmark #381

merged 11 commits into from
Nov 2, 2024

Conversation

j-h-li
Copy link
Contributor

@j-h-li j-h-li commented Aug 14, 2024

changed subgoal to benchmark

@BeeSeeWhy BeeSeeWhy self-requested a review August 23, 2024 00:22
Copy link
Contributor

@BeeSeeWhy BeeSeeWhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, but it looks like there are some conflicts that need to be resolved before we can merge. Also, I don't see components/benchmark folder added along the files, but I see components/subgoal files deleted. Should this all be deleted?
Screenshot 2024-08-22 at 5 33 49 PM

@francisli francisli linked an issue Sep 18, 2024 that may be closed by this pull request
@thomhickey
Copy link
Contributor

The changes look good, but it looks like there are some conflicts that need to be resolved before we can merge. Also, I don't see components/benchmark folder added along the files, but I see components/subgoal files deleted. Should this all be deleted? Screenshot 2024-08-22 at 5 33 49 PM

Yes @BeeSeeWhy, those files need to be replaced or references to them need to be removed, but the missing files are causing problems as there are still imports pointing to them.

@KCCPMG
Copy link
Contributor

KCCPMG commented Oct 22, 2024

The changes look good, but it looks like there are some conflicts that need to be resolved before we can merge. Also, I don't see components/benchmark folder added along the files, but I see components/subgoal files deleted. Should this all be deleted? Screenshot 2024-08-22 at 5 33 49 PM

I believe this is good to go. There is src/components/benchmarks, let me know if there's anything else that you notice as being out of place or missing.

@KCCPMG
Copy link
Contributor

KCCPMG commented Oct 27, 2024

This should hopefully now be up to date and working in light off the most recent updates on main. @canjalal and @thomhickey, you may want to check specifically to make sure that the latest addSubgoal/addBenchmark tests haven't gotten mangled by the change in terms.

Copy link
Contributor

@katconnors katconnors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comparing main vs this branch's behavior, there's something to note:
when loading student pages that don't have benchmarks, there are 500 errors in the terminal, and the page is slow to load.

That being said, the code looked good prior to the behavior check, so I'm not sure what is causing this.

@KCCPMG
Copy link
Contributor

KCCPMG commented Oct 31, 2024

Comparing main vs this branch's behavior, there's something to note: when loading student pages that don't have benchmarks, there are 500 errors in the terminal, and the page is slow to load.

That being said, the code looked good prior to the behavior check, so I'm not sure what is causing this.

Thanks for the feedback, I'll take a look! I'm assuming this was after resetting the database? Were there any issues when doing so?

@katconnors
Copy link
Contributor

Comparing main vs this branch's behavior, there's something to note: when loading student pages that don't have benchmarks, there are 500 errors in the terminal, and the page is slow to load.
That being said, the code looked good prior to the behavior check, so I'm not sure what is causing this.

Thanks for the feedback, I'll take a look! I'm assuming this was after resetting the database? Were there any issues when doing so?

My mistake! I didn't reset the db. I'll update my review to approve. Sorry about that, Connor!

@katconnors katconnors self-requested a review November 1, 2024 18:01
Copy link
Contributor

@katconnors katconnors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating to approve- no 500 errors after db reset.

@KCCPMG
Copy link
Contributor

KCCPMG commented Nov 2, 2024

Updating to approve- no 500 errors after db reset.

Awesome, thank you, Katrina!

@KCCPMG KCCPMG dismissed BeeSeeWhy’s stale review November 2, 2024 03:40

Conflicts resolved, outstanding subgoal components renamed appropriately

@KCCPMG KCCPMG merged commit 406cf35 into main Nov 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename "subgoal" copy to "benchmark"
5 participants