-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
364 ticket, changed subgoal to benchmark #381
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes @BeeSeeWhy, those files need to be replaced or references to them need to be removed, but the missing files are causing problems as there are still imports pointing to them. |
…de where appropriate
…ause conflict on merge, correct variable name in iep test from incorrect replacement in merge
This should hopefully now be up to date and working in light off the most recent updates on main. @canjalal and @thomhickey, you may want to check specifically to make sure that the latest addSubgoal/addBenchmark tests haven't gotten mangled by the change in terms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comparing main vs this branch's behavior, there's something to note:
when loading student pages that don't have benchmarks, there are 500 errors in the terminal, and the page is slow to load.
That being said, the code looked good prior to the behavior check, so I'm not sure what is causing this.
Thanks for the feedback, I'll take a look! I'm assuming this was after resetting the database? Were there any issues when doing so? |
My mistake! I didn't reset the db. I'll update my review to approve. Sorry about that, Connor! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating to approve- no 500 errors after db reset.
Awesome, thank you, Katrina! |
Conflicts resolved, outstanding subgoal components renamed appropriately
changed subgoal to benchmark