Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling for staff page [ENG] #358

Open
2 tasks
katconnors opened this issue Jul 24, 2024 · 3 comments
Open
2 tasks

Styling for staff page [ENG] #358

katconnors opened this issue Jul 24, 2024 · 3 comments
Labels
design Something for the design team to work on engineering

Comments

@katconnors
Copy link
Contributor

katconnors commented Jul 24, 2024

Styling is consistent between the individual student and staff pages, but a bit jarring due to small number of columns in staff page.

  • Reach out to design regarding styling of staff page (optional)
  • Change styling for staff page

Current student page (after clicking into a specific student page):
image

Current staff page (after clicking into a specific staff page):
image

@katconnors katconnors changed the title Styling for staff page Styling for staff page [ENG] Jul 31, 2024
@katconnors katconnors moved this to Todo in Compass Jul 31, 2024
@katconnors katconnors added the design Something for the design team to work on label Aug 14, 2024
@katconnors
Copy link
Contributor Author

Engineer that wants to take this on can make a decision or reach out to design team first (updated goals)

@nickvisut
Copy link
Contributor

Looked into the justification weirdness and it turns out that each field label + value pair is horizontally centered, which gives the illusion that the justification is different b/t the two pages. It's still offputting, either way, so I suggest revamping design to make it more obvious what belongs where or changing justification to something more table-like.

@nickvisut nickvisut removed their assignment Aug 28, 2024
@nickvisut nickvisut moved this from In Development to Blocked / On hold in Compass Aug 28, 2024
@nickvisut
Copy link
Contributor

Must reach out to UX to see if this is an item that ought to be tackled (eg, left justify for all fields except # which are right justify)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Something for the design team to work on engineering
Projects
Status: Blocked / On hold
Development

No branches or pull requests

2 participants