Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated edit staff modal to match edit student modal #346

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sjwhitman
Copy link

No description provided.

@sjwhitman sjwhitman requested a review from hannahmcg June 21, 2024 06:21
@BeeSeeWhy BeeSeeWhy self-requested a review June 21, 2024 20:58
@sjwhitman sjwhitman linked an issue Jun 21, 2024 that may be closed by this pull request
Copy link
Contributor

@BeeSeeWhy BeeSeeWhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I run this, the modal does not appear, nor does the old page appear.

@katconnors
Copy link
Contributor

No glaring changes that I can see- this looks pretty on par with the student modal code.

Functionality is good. I also checked for self archiving (an error appeared, so that's good) and other staff archiving.

May want to style the page (the one prior to opening the modal), but that's out of scope of this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Edit Staff using edit student Modal as a model
3 participants