Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert maven-checkstyle-plugin run to ant run #915

Closed
rnveach opened this issue Oct 23, 2022 · 1 comment
Closed

Convert maven-checkstyle-plugin run to ant run #915

rnveach opened this issue Oct 23, 2022 · 1 comment
Labels
approved miscellaneous
Milestone
1.43.0

Comments

@rnveach
Copy link
Contributor

rnveach commented Oct 23, 2022 •
edited
Loading

Similar to checkstyle/contribution#273 and checkstyle/checkstyle#5385 ,

We need to deprecate all usage of maven-checkstyle-plugin so we can start implementing backward breaking changes.

Note that this had a breaking change in the repo's skip property for only Checkstyle execution. The property checkstyle.skip was changed to checkstyle.ant.skip to differentiate it from normal maven-plugin skip.

No other properties or execution was changed.
@rnveach rnveach mentioned this issue Oct 23, 2022
Merged
rnveach added a commit to rnveach/checkstyle that referenced this issue Oct 23, 2022
@rnveach
supplemental: ant switch in sevntu-checkstyle/sevntu.checkstyle#915
94c6f32
rnveach added a commit that referenced this issue Oct 23, 2022
@rnveach
Issue #915: convert maven-checkstyle-plugin to ant
8b469f8
@rnveach
Copy link
Contributor Author

rnveach commented Oct 23, 2022

Fix was merged

@rnveach rnveach closed this as completed Oct 23, 2022
@rnveach rnveach added this to the 1.43.0 milestone Oct 23, 2022
rnveach added a commit that referenced this issue Oct 23, 2022
@rnveach
Issue #915: correct handling of checkstyle.ant.skip
877e98b
rnveach added a commit to checkstyle/checkstyle that referenced this issue Oct 23, 2022
@rnveach
supplemental: ant switch in sevntu-checkstyle/sevntu.checkstyle#915
e5b56f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved miscellaneous
Projects
None yet
Milestone
1.43.0
Development

No branches or pull requests
2 participants
@romani @rnveach