Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue adding new structures from the database #10

Open
jacobjma opened this issue Nov 30, 2021 · 2 comments
Open

Issue adding new structures from the database #10

jacobjma opened this issue Nov 30, 2021 · 2 comments

Comments

@jacobjma
Copy link

Thank you, I really like this program.

I have an issue when adding new structures from the crystal database.

For example, when I add Mn3Si with a lattice constant of 5.722 Å, the cell volume is given as 1873456270480000 Å^3. It seems that it is not correctly interpreting the decimal separator since 5722^3 = 1873456270480000.

I suspect the issue is due to using a danish language operating system where the "," (comma) is used as a decimal separator.

I would suggest always using the "." (dot) separator. I think most scientists prefer the dot separator, despite the convention of their respective countries.

I am also not able to open Structure Viewer for newly added structures, however, I think this is directly related to the above issue.

System:
Windows 11
.Net 6.0
ReciPro ver4.826(2021/11/18)

@seto77
Copy link
Owner

seto77 commented Dec 1, 2021

Thank you very much for reporting the bug.

As you pointed out, the cause of this problem seems to be that the symbols for the decimal point separator and the 3-digit separator are different in different cultures (which is defined by OS setting).

Since the conversion from strings to numbers is done in various places in the program, it will take some time to fix everything. In the new version (ver4.827), I have improved the behaviour when importing crystal structures from the database. Please give it a try.

@jacobjma
Copy link
Author

jacobjma commented Dec 1, 2021

Thank you. I can confirm that ver4.827 fixes the issue.

I have not encountered the issue anywhere else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants