Repository navigation
Deprecate insert_many (and add splice?) #255
Description
The insert_many function is complicated, and has had several bugs and vulnerabilities (#96, #208, #252). Unlike most SmallVec methods, it does not correspond to a standard Vec method. Perhaps because of this, it is rarely used. Should we deprecate this method, and remove it in the next major version?
The standard Vec::splice method could be used in place of insert_many, but SmallVec does not yet implement this method. We could add this, possibly by copying the implementation from std::vec, if there is demand for it.
Activity
lopopolo commentedon Jan 8, 2021
@mbrubeck I would like to put in a request for a
Vec::spliceequivalent API.I've implemented a crate that exposes several types that would be appropriate to implement Ruby's
Arrayclass. This crate has multiple backends, includingVecandSmallVec. Ruby has anArray#[]=API which in one of its forms acts likeVec::splice: replace a subslice of theArraywith another slice.The
SmallVecimplementation is several times larger and scarier than theVecimplementation.SmallVec: https://github.com/artichoke/artichoke/blob/ae3fa8adc8e26d74a6ee566e2065b79db5b09fc8/spinoso-array/src/array/smallvec/mod.rs#L1093L1157Vec: https://github.com/artichoke/artichoke/blob/ae3fa8adc8e26d74a6ee566e2065b79db5b09fc8/spinoso-array/src/array/vec/mod.rs#L1124-L1141spinoso_array::SmallArray::set_slicemight be a starting point for aSmallVec::spliceimplementation (MIT licensed). It uses no unsafe code.[-]Deprecate insert_many?[/-][+]Deprecate insert_many (and add splice?)[/+]