From 48c1a31561f997dfcd76b755102893b7913d3b56 Mon Sep 17 00:00:00 2001 From: Samson <16504129+sagudev@users.noreply.github.com> Date: Thu, 29 Feb 2024 18:34:21 +0100 Subject: [PATCH] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Sebastian Dröge --- backends/gstreamer/datachannel.rs | 3 +-- backends/gstreamer/lib.rs | 3 +-- backends/gstreamer/source.rs | 1 - 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/backends/gstreamer/datachannel.rs b/backends/gstreamer/datachannel.rs index b6735064..6653f31d 100644 --- a/backends/gstreamer/datachannel.rs +++ b/backends/gstreamer/datachannel.rs @@ -1,5 +1,4 @@ -use glib::object::ObjectExt; -use glib::value::ToSendValue; +use glib::prelude::*; use gst_webrtc::{WebRTCDataChannel, WebRTCDataChannelState}; use servo_media_webrtc::thread::InternalEvent; use servo_media_webrtc::WebRtcController as WebRtcThread; diff --git a/backends/gstreamer/lib.rs b/backends/gstreamer/lib.rs index 2cc812ee..0f302956 100644 --- a/backends/gstreamer/lib.rs +++ b/backends/gstreamer/lib.rs @@ -18,8 +18,7 @@ use ipc_channel::ipc::IpcSender; use log::warn; use media_stream::GStreamerMediaStream; use mime::Mime; -use once_cell::sync::Lazy; -use once_cell::sync::OnceCell; +use once_cell::sync::{Lazy, OnceCell}; use registry_scanner::GSTREAMER_REGISTRY_SCANNER; use servo_media::{Backend, BackendInit, SupportsMediaType}; use servo_media_audio::context::{AudioContext, AudioContextOptions}; diff --git a/backends/gstreamer/source.rs b/backends/gstreamer/source.rs index 74743dc2..87a39003 100644 --- a/backends/gstreamer/source.rs +++ b/backends/gstreamer/source.rs @@ -243,7 +243,6 @@ mod imp { let pad_templ = klass.pad_template("src").unwrap(); let ghost_pad = gst::GhostPad::builder_from_template(&pad_templ) - .name("src") .query_function(|pad, parent, query| { ServoSrc::catch_panic_pad_function( parent,