Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to std::process::Command #53

Open
ebkalderon opened this issue Dec 3, 2018 · 0 comments
Open

Switch to std::process::Command #53

ebkalderon opened this issue Dec 3, 2018 · 0 comments

Comments

@ebkalderon
Copy link

Is there any technical reason for gaol to provide its own Command abstraction over using what's available in std::process::Command? The biggest functional difference I noticed is that the gaol provided Command uses execve() to specify the environment on the spawned process while std::process::Command uses execvp(). Despite this difference, however, std::process::Command also allows for the command environment to be set with the env() and envs() methods. Is there any particular barrier preventing gaol from switching wholesale to the std implementation?

I ask because there are some useful crates, e.g. tokio-process, which directly accept or implement extra traits on top of std::process::Command, and it would be quite nice to use gaol with these libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant