Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gaol does not set sandboxed process current working directory #42

Open
rocallahan opened this issue Jan 20, 2018 · 1 comment
Open

gaol does not set sandboxed process current working directory #42

rocallahan opened this issue Jan 20, 2018 · 1 comment

Comments

@rocallahan
Copy link

After spawning a jailed subprocess, its current working directory is unchanged, so it can actually be outside the subprocess' sandbox which I believe means it can access files outside the sandbox. This is bad.

@rocallahan
Copy link
Author

platform/linux/namespace.rs does

 match env::set_current_dir(&Path::new(".")) {

That's a no-op AFAIK. It should probably chdir to root.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant