Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use JUnit 5 #35

Closed
JonMR opened this issue Oct 12, 2018 · 1 comment · Fixed by #38
Closed

Use JUnit 5 #35

JonMR opened this issue Oct 12, 2018 · 1 comment · Fixed by #38
Assignees
@darkmoonka
Labels
hacktoberfest

Comments

@JonMR
Copy link
Contributor

JonMR commented Oct 12, 2018

Split from #33.

See my comment which discusses some of JUnit 5 and dropwizard.

The tricky part will be the removal of rules. Since we wrap one rule with another rule. Need to figure out how to do that with extensions.

This will have to be built on top of #34 since JUnit 5 requires Java 8.
@JonMR JonMR mentioned this issue Oct 12, 2018
Open
@darkmoonka
Copy link

Hi @JonMR,
can you please assign this to me? I would push my solution

@darkmoonka darkmoonka mentioned this issue Oct 12, 2019
Merged
@JonMR JonMR closed this as completed in #38 Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darkmoonka darkmoonka

Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use JUnit 5 #35 darkmoonka/dropwizard-request-tracker
2 participants
@JonMR @darkmoonka