Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Selective auth? #75

Closed
koutsie opened this issue Sep 7, 2021 · 4 comments
Closed

Feature request: Selective auth? #75

koutsie opened this issue Sep 7, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@koutsie
Copy link
Contributor

koutsie commented Sep 7, 2021

Eg: I'd like the auth key be asked for everything else but for example getting a scoreboard.
This'd make fetching stuff client side (eg a website with js) possible "securely" (not exposing ex: add ops to the client (because they don't need the key to get what they need))

@c1oneman
Copy link
Contributor

c1oneman commented Sep 7, 2021

One solution is to build a middleware API for your own system to handle auth and routes.

@koutsie
Copy link
Contributor Author

koutsie commented Sep 7, 2021

One solution is to build a middleware API for your own system to handle auth and routes.

Yeah is, but i guess what i'm trying to say is to have an "publicly accesible" server api so that people can fetch public data permissively.

Tho yes that could also be trough the middleware-api*

@phybros
Copy link
Collaborator

phybros commented Sep 16, 2021

@c1oneman you actually already implemented this but didn't know it.

Just have to change this line to be the swagger paths PLUS a list from the config file :) https://github.com/phybros/servertap/blob/50ae4637406ae7be96558e0f20e824df223c713d/src/main/java/io/servertap/PluginEntrypoint.java#L107

@phybros
Copy link
Collaborator

phybros commented Dec 17, 2021

Closing this in favor of #6 I will ensure this is possible in the new auth system

@phybros phybros closed this as completed Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants