(Deniz Akşimşek) Implement carousel scraper #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My submission for the code challenge.
I tried to replicate the data in expected-array.json exactly (for the HTML file provided), which required some encoding-related code. These are marked with comments in the code, as I wasn't sure if identical encoding of e.g. quote marks in URLs was required, but implemented it anyway for the sake of easy verification of the results.
The Google carousel seems to have changed in the time between now and the creation of van-gogh-paintings.html (I added current examples under files/). My code successfully parses both the old and the current carousels.