Add validation for adding a new Job

[sero-dev]

Add validation for adding a new Job to the database. Validate whether the request object is valid.

A job can be saved in the database if it fulfills the following criteria:

• Job Title is not empty
• Employer is not empty
• City is not empty
• State is not empty and a valid US State
• Status is not empty and is one of the following:
  • Applied
  • Rejected
  • Declined
  • Accepted
  • Offered
  • Code Challenge
  • Interview
  • Messed Up
  • Phone Call
  • Under Review
• Amenities is not null

If DateSubmitted is null, the date will be set to Now.
If DateUpdated is null, the date will be set to DateSubmitted.

• Learn how to use FluentValidation
• Add Validation to Command/Query classes as a pre-action
• Create unit tests for testing validation rules

[b13peterson]

I have experience with FluentValidation and can take care of this in the next few days

[sero-dev]

Just a heads up, in case my changes go before yours. I'll be changing to MongoDB (which shouldn't affect you at all) and I ended up moving the models in the Domain layer outside of the Entities folder (which would give you namespace conflicts, which will most likely be easy to resolve).

[b13peterson]

Currently the DateSubmitted and DateUpdated properties of Job are not nullable. My initial thought is to change their type to 'DateTime?', but let me know if you'd prefer that I validate against the default DateTime value.

Would you like me to create a pull request to the develop branch or would you prefer to create a new validation-addition branch? I don't seem to have access to create a branch, but I'm new to GitHub so I may be missing something.

[sero-dev]

There's a DTO for creating a job.
https://github.com/sero-dev/JobHunt/blob/master/Source/Application/DTOs/CreateJobRequest.cs

We should be validating the DTO, Having those fields null are valid because after validation and during the mapping process, null dates will be set to today. This is the mapping that does that:
https://github.com/sero-dev/JobHunt/blob/master/Source/Application/Mappings/JobProfile.cs

Originally, I had added that

If DateSubmitted is null, the date will be set to Now.
If DateUpdated is null, the date will be set to DateSubmitted.

This has already been done when using AutoMapper. I forgot to update the issue.

There is no develop branch anymore. You will need to fork the repository, make a branch off of master and commit your changes on that branch, then make a Pull Request into this repository. There are GitHub Actions that will build and test your incoming changes to ensure the rest of the application is working as intended.